[polari/wip/fmuellner/combined-gsoc: 117/137] use the notify action name as an id for the notification
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [polari/wip/fmuellner/combined-gsoc: 117/137] use the notify action name as an id for the notification
- Date: Thu, 28 Jul 2016 16:25:17 +0000 (UTC)
commit 13063ff56c29a27bb16db481f9cdfc10020ac994
Author: raresv <rares visalom gmail com>
Date: Sun Jul 24 19:38:42 2016 +0300
use the notify action name as an id for the notification
src/userTracker.js | 12 +-----------
1 files changed, 1 insertions(+), 11 deletions(-)
---
diff --git a/src/userTracker.js b/src/userTracker.js
index 7e45415..0ff6757 100644
--- a/src/userTracker.js
+++ b/src/userTracker.js
@@ -334,17 +334,7 @@ const UserTracker = new Lang.Class({
Utils.getTpEventTime() ]);
notification.set_default_action_and_target('app.join-room', param);
- /* Passing an ID of null would be better than a common one:
- * If two watched users come online roughly at the same time, the
- * first notification is dismissed and replaced by the second.
- *
- * But then maybe it makes sense to withdraw a notification if a
- * watched user disconnects again? In that case, using something
- * unique similar to getNotifyActionName() should work (maybe just
- * split out a private _getNotifyActionName() that is shared between
- * the public method and the notification ID, i.e. the name part
- * only without the side-effect of creating an action */
- this._app.send_notification('watched-user-notification', notification);
+ this._app.send_notification(this._getNotifyActionName(member.alias), notification);
let baseNick = Polari.util_get_basenick(member.alias);
},
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]