[pygobject] build: Do not enable code coverage based on lcov
- From: Emmanuele Bassi <ebassi src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [pygobject] build: Do not enable code coverage based on lcov
- Date: Wed, 23 Mar 2016 15:19:28 +0000 (UTC)
commit 6ff29c91dfdbcc3203405da0aca8dbfa318d8b32
Author: Emmanuele Bassi <ebassi gnome org>
Date: Wed Mar 23 13:59:53 2016 +0000
build: Do not enable code coverage based on lcov
Code coverage turns on various slow paths and disables optimizations. It
should be, and it usually is, an opt in configuration flag.
Enabling it should not be conditional on the existence of the lcov
binary on the system, otherwise anybody building PyGObject from Git on
any moderately complete development environment will automatically
enable code coverage even when not wanted.
https://bugzilla.gnome.org/show_bug.cgi?id=764075
autogen.sh | 10 +---------
1 files changed, 1 insertions(+), 9 deletions(-)
---
diff --git a/autogen.sh b/autogen.sh
index 3c7605d..f58b081 100755
--- a/autogen.sh
+++ b/autogen.sh
@@ -13,17 +13,9 @@ PKG_NAME="pygobject"
exit 1
}
-if type lcov >/dev/null 2>&1; then
- EXTRA_ARGS="--enable-code-coverage"
-else
- echo "lcov not installed, not enabling code coverage"
-fi
-
-
which gnome-autogen.sh || {
echo "You need to install gnome-common."
exit 1
}
-. gnome-autogen.sh "$EXTRA_ARGS" "$@"
-
+. gnome-autogen.sh "$@"
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]