[gnome-software/wip/temp/ubuntu-xenial-rebased-corrected: 28/331] Drop special plugin function to report reviews support - we just need to check if the plugin has gs_
- From: William Hua <williamhua src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-software/wip/temp/ubuntu-xenial-rebased-corrected: 28/331] Drop special plugin function to report reviews support - we just need to check if the plugin has gs_
- Date: Wed, 4 May 2016 14:00:52 +0000 (UTC)
commit 31df74fbbc31498f0f4ffe4b5680e21dd2dea8fc
Author: Robert Ancell <robert ancell canonical com>
Date: Thu Feb 4 16:56:55 2016 +1300
Drop special plugin function to report reviews support - we just need to check if the plugin has
gs_plugin_app_set_review defined
src/gs-plugin-loader.c | 7 +++----
src/gs-plugin.h | 1 -
2 files changed, 3 insertions(+), 5 deletions(-)
---
diff --git a/src/gs-plugin-loader.c b/src/gs-plugin-loader.c
index 46093d4..3c732b3 100644
--- a/src/gs-plugin-loader.c
+++ b/src/gs-plugin-loader.c
@@ -2948,10 +2948,9 @@ gs_plugin_loader_open_plugin (GsPluginLoader *plugin_loader,
(gpointer *) &plugin_conflicts);
/* Check if this plugin can do reviews */
- (void) g_module_symbol (module,
- "gs_plugin_get_supports_reviews",
- (gpointer *) &plugin_supports_reviews);
- if (plugin_supports_reviews && plugin_supports_reviews (plugin))
+ if (g_module_symbol (module,
+ "gs_plugin_app_set_review",
+ NULL))
priv->supports_reviews = TRUE;
/* print what we know */
diff --git a/src/gs-plugin.h b/src/gs-plugin.h
index c512143..c1862e1 100644
--- a/src/gs-plugin.h
+++ b/src/gs-plugin.h
@@ -148,7 +148,6 @@ typedef enum {
typedef const gchar *(*GsPluginGetNameFunc) (void);
typedef const gchar **(*GsPluginGetDepsFunc) (GsPlugin *plugin);
-typedef gboolean *(*GsPluginGetSupportsReviewsFunc) (GsPlugin *plugin);
typedef void (*GsPluginFunc) (GsPlugin *plugin);
typedef gboolean (*GsPluginSetupFunc) (GsPlugin *plugin,
GCancellable *cancellable,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]