[gimp] libgimpwidgets: remove gimp_color_profile_chooser_dialog_new()
- From: Michael Natterer <mitch src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] libgimpwidgets: remove gimp_color_profile_chooser_dialog_new()
- Date: Fri, 6 May 2016 20:57:48 +0000 (UTC)
commit 2bfd0711e8ea42acf63f1424e4b585e51f83925c
Author: Michael Natterer <mitch gimp org>
Date: Fri May 6 22:55:06 2016 +0200
libgimpwidgets: remove gimp_color_profile_chooser_dialog_new()
Its API was too limited, and adding parameters for what we need next
would be equally random. It's a rarely used and mostly internal
widget, so simply use g_object_new().
app/dialogs/color-profile-dialog.c | 5 +++--
app/dialogs/preferences-dialog.c | 8 ++++++--
.../libgimpwidgets/libgimpwidgets-sections.txt | 1 -
libgimpwidgets/gimpcolorprofilechooserdialog.c | 9 ---------
libgimpwidgets/gimpcolorprofilechooserdialog.h | 3 +--
libgimpwidgets/gimpwidgets.def | 1 -
modules/display-filter-proof.c | 4 +++-
7 files changed, 13 insertions(+), 18 deletions(-)
---
diff --git a/app/dialogs/color-profile-dialog.c b/app/dialogs/color-profile-dialog.c
index 2631859..89e94f1 100644
--- a/app/dialogs/color-profile-dialog.c
+++ b/app/dialogs/color-profile-dialog.c
@@ -330,8 +330,9 @@ color_profile_combo_box_new (ProfileDialog *dialog)
gchar *label;
GError *error = NULL;
- chooser =
- gimp_color_profile_chooser_dialog_new (_("Select destination profile"));
+ chooser = g_object_new (GIMP_TYPE_COLOR_PROFILE_CHOOSER_DIALOG,
+ "title", _("Select Destination Profile"),
+ NULL);
history = gimp_personal_rc_file ("profilerc");
combo = gimp_color_profile_combo_box_new (chooser, history);
diff --git a/app/dialogs/preferences-dialog.c b/app/dialogs/preferences-dialog.c
index baacd03..d838e3c 100644
--- a/app/dialogs/preferences-dialog.c
+++ b/app/dialogs/preferences-dialog.c
@@ -802,7 +802,7 @@ static void prefs_profile_combo_notify (GObject *config,
const GParamSpec *param_spec,
GimpColorProfileComboBox *combo);
- static void
+static void
prefs_profile_combo_changed (GimpColorProfileComboBox *combo,
GObject *config)
{
@@ -887,12 +887,16 @@ prefs_profile_combo_box_new (GObject *config,
const gchar *label,
const gchar *property_name)
{
- GtkWidget *dialog = gimp_color_profile_chooser_dialog_new (label);
+ GtkWidget *dialog;
GtkWidget *combo;
gchar *path;
gchar *notify_name;
GFile *file = NULL;
+ dialog = g_object_new (GIMP_TYPE_COLOR_PROFILE_CHOOSER_DIALOG,
+ "title", label,
+ NULL);
+
g_object_get (config, property_name, &path, NULL);
if (path)
diff --git a/devel-docs/libgimpwidgets/libgimpwidgets-sections.txt
b/devel-docs/libgimpwidgets/libgimpwidgets-sections.txt
index ba9c1a0..009dbef 100644
--- a/devel-docs/libgimpwidgets/libgimpwidgets-sections.txt
+++ b/devel-docs/libgimpwidgets/libgimpwidgets-sections.txt
@@ -205,7 +205,6 @@ GIMP_COLOR_SELECTION_GET_CLASS
<SECTION>
<FILE>gimpcolorprofilechooserdialog</FILE>
<TITLE>GimpColorProfileChooserDialog</TITLE>
-gimp_color_profile_chooser_dialog_new
<SUBSECTION Standard>
GIMP_COLOR_PROFILE_CHOOSER_DIALOG
GIMP_COLOR_PROFILE_CHOOSER_DIALOG_CLASS
diff --git a/libgimpwidgets/gimpcolorprofilechooserdialog.c b/libgimpwidgets/gimpcolorprofilechooserdialog.c
index d5cc4b4..107df25 100644
--- a/libgimpwidgets/gimpcolorprofilechooserdialog.c
+++ b/libgimpwidgets/gimpcolorprofilechooserdialog.c
@@ -137,15 +137,6 @@ gimp_color_profile_chooser_dialog_constructed (GObject *object)
NULL);
}
-GtkWidget *
-gimp_color_profile_chooser_dialog_new (const gchar *title)
-{
-
- return g_object_new (GIMP_TYPE_COLOR_PROFILE_CHOOSER_DIALOG,
- "title", title,
- NULL);
-}
-
/* Add shortcuts for default ICC profile locations */
static gboolean
add_shortcut (GimpColorProfileChooserDialog *dialog,
diff --git a/libgimpwidgets/gimpcolorprofilechooserdialog.h b/libgimpwidgets/gimpcolorprofilechooserdialog.h
index cc82fa2..42c9711 100644
--- a/libgimpwidgets/gimpcolorprofilechooserdialog.h
+++ b/libgimpwidgets/gimpcolorprofilechooserdialog.h
@@ -55,9 +55,8 @@ struct _GimpColorProfileChooserDialogClass
};
-GType gimp_color_profile_chooser_dialog_get_type (void) G_GNUC_CONST;
+GType gimp_color_profile_chooser_dialog_get_type (void) G_GNUC_CONST;
-GtkWidget * gimp_color_profile_chooser_dialog_new (const gchar *title);
G_END_DECLS
diff --git a/libgimpwidgets/gimpwidgets.def b/libgimpwidgets/gimpwidgets.def
index 50cdae4..6a07515 100644
--- a/libgimpwidgets/gimpwidgets.def
+++ b/libgimpwidgets/gimpwidgets.def
@@ -74,7 +74,6 @@ EXPORTS
gimp_color_notebook_set_has_page
gimp_color_picker_cursors_get_resource
gimp_color_profile_chooser_dialog_get_type
- gimp_color_profile_chooser_dialog_new
gimp_color_profile_combo_box_add
gimp_color_profile_combo_box_add_file
gimp_color_profile_combo_box_get_active
diff --git a/modules/display-filter-proof.c b/modules/display-filter-proof.c
index 4f06263..0f918b3 100644
--- a/modules/display-filter-proof.c
+++ b/modules/display-filter-proof.c
@@ -301,7 +301,9 @@ cdisplay_proof_configure (GimpColorDisplay *display)
gtk_table_set_col_spacings (GTK_TABLE (table), 6);
gtk_table_set_row_spacings (GTK_TABLE (table), 6);
- dialog = gimp_color_profile_chooser_dialog_new (_("Choose an ICC Color Profile"));
+ dialog = g_object_new (GIMP_TYPE_COLOR_PROFILE_CHOOSER_DIALOG,
+ "title", _("Choose an ICC Color Profile"),
+ NULL);
history = gimp_personal_rc_file ("profilerc");
combo = gimp_color_profile_combo_box_new (dialog, history);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]