[evolution] Message list not always scrolled to the cursor position on folder enter
- From: Milan Crha <mcrha src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evolution] Message list not always scrolled to the cursor position on folder enter
- Date: Fri, 11 Nov 2016 10:06:07 +0000 (UTC)
commit ed951a9190b2752f51267b7dcb27585505413890
Author: Milan Crha <mcrha redhat com>
Date: Fri Nov 11 11:03:50 2016 +0100
Message list not always scrolled to the cursor position on folder enter
There could happen that a folder's "changed" signal had been received
before an ongoing message list regen got processed, which meant that
the ongoing regen request had been updated, not cancelled, but as it
also modified the folder_changed flag, then the scroll position had not
been updated properly.
src/mail/message-list.c | 8 +++++++-
1 files changed, 7 insertions(+), 1 deletions(-)
---
diff --git a/src/mail/message-list.c b/src/mail/message-list.c
index d698e7f..e7c4f8e 100644
--- a/src/mail/message-list.c
+++ b/src/mail/message-list.c
@@ -6326,7 +6326,13 @@ mail_regen_list (MessageList *message_list,
old_regen_data->search = g_strdup (search);
}
- old_regen_data->folder_changed = folder_changed;
+ /* Only turn off the folder_changed flag, do not turn it on, because otherwise
+ the view may not scroll to the cursor position, due to claiming that
+ the regen was done for folder-changed signal, while the initial regen
+ request would be due to change of the folder in the view (or other similar
+ reasons). */
+ if (!folder_changed)
+ old_regen_data->folder_changed = folder_changed;
/* Avoid cancelling on the way out. */
old_regen_data = NULL;
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]