[rhythmbox] transfer-target: don't bother sanitising URIs here



commit b9d0e243387a759ca7a1b545641cd18725a04138
Author: Jonathan Matthew <jonathan d14n org>
Date:   Mon Oct 3 08:32:36 2016 +1000

    transfer-target: don't bother sanitising URIs here
    
    If the target implementation knows what type of filesystem it's dealing
    with, it can do a better job of this while it's building the destination
    URI.  Otherwise, the encoder backend will make URIs safe for FAT filesystems
    if it can't open the original URI.
    
    This method also involves a lot of synchronous gvfs operations on the main
    thread, which causes problems with slower device filesystems.

 sources/rb-transfer-target.c |    7 -------
 1 files changed, 0 insertions(+), 7 deletions(-)
---
diff --git a/sources/rb-transfer-target.c b/sources/rb-transfer-target.c
index cfd303f..0692576 100644
--- a/sources/rb-transfer-target.c
+++ b/sources/rb-transfer-target.c
@@ -90,13 +90,6 @@ rb_transfer_target_build_dest_uri (RBTransferTarget *target,
 
        uri = iface->build_dest_uri (target, entry, media_type, extension);
        if (uri != NULL) {
-               char *sane_uri;
-
-               sane_uri = rb_sanitize_uri_for_filesystem (uri, NULL);
-               g_return_val_if_fail (sane_uri != NULL, NULL);
-               g_free (uri);
-               uri = sane_uri;
-
                rb_debug ("built dest uri for media type '%s', extension '%s': %s",
                          media_type, extension, uri);
        } else {


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]