[evince] libdocument: Use a byte rather than an unsigned int for memset
- From: Carlos Garcia Campos <carlosgc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [evince] libdocument: Use a byte rather than an unsigned int for memset
- Date: Sat, 19 Aug 2017 06:54:15 +0000 (UTC)
commit 3779d1e0d6ffd8c616954295e8dcc4e110660fa8
Author: Tobias Mueller <muelli cryptobitch de>
Date: Wed Aug 16 19:06:00 2017 +0200
libdocument: Use a byte rather than an unsigned int for memset
Currently, gcc emits a warning for the constant used in the memset call.
memset really sets a byte, so let's use one here, instead of the bigger
unsigned integer.
ev-document-misc.c:77:40: warning: conversion of unsigned constant value
to negative integer [-Wsign-conversion]
memset (data + (rowstride * i) + 4, 0xffffffff, nbytes);
https://bugzilla.gnome.org/show_bug.cgi?id=786415
libdocument/ev-document-misc.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/libdocument/ev-document-misc.c b/libdocument/ev-document-misc.c
index a3ba592..bb1dd1a 100644
--- a/libdocument/ev-document-misc.c
+++ b/libdocument/ev-document-misc.c
@@ -70,7 +70,7 @@ create_thumbnail_frame (int width,
gdk_pixbuf_fill (retval, 0x000000ff);
if (fill_bg) {
for (i = 1; i < height_r + 1; i++)
- memset (data + (rowstride * i) + 4, 0xffffffff, width_r * 4);
+ memset (data + (rowstride * i) + 4, 0xff, width_r * 4);
}
/* copy the source pixbuf */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]