[gnome-software/wip/ubuntu-master] snap: Install classic snaps

[Robert Ancell <rancell src gnome org>]

commit 3f50148b9b8a57b79ca31f41f7820f7264754908
Author: Robert Ancell <robert ancell canonical com>
Date:   Thu Aug 24 14:26:16 2017 +1200

    snap: Install classic snaps

 plugins/snap/gs-plugin-snap.c |   15 +++++++++++++--
 1 files changed, 13 insertions(+), 2 deletions(-)
---
diff --git a/plugins/snap/gs-plugin-snap.c b/plugins/snap/gs-plugin-snap.c
index e1bae3f..a6469f3 100644
--- a/plugins/snap/gs-plugin-snap.c
+++ b/plugins/snap/gs-plugin-snap.c
@@ -239,6 +239,8 @@ snap_to_app (GsPlugin *plugin, SnapdSnap *snap)
 {
        GsPluginData *priv = gs_plugin_get_data (plugin);
        GsApp *app;
+       SnapdConfinement confinement;
+       GEnumClass *enum_class;
 
        /* create a unique ID for deduplication, TODO: branch? */
        app = gs_app_new (snapd_snap_get_name (snap));
@@ -262,7 +264,13 @@ snap_to_app (GsPlugin *plugin, SnapdSnap *snap)
        gs_app_add_quirk (app, AS_APP_QUIRK_NOT_REVIEWABLE);
        if (gs_plugin_check_distro_id (plugin, "ubuntu"))
                gs_app_add_quirk (app, AS_APP_QUIRK_PROVENANCE);
-       if (priv->system_confinement == SNAPD_SYSTEM_CONFINEMENT_STRICT && snapd_snap_get_confinement (snap) 
== SNAPD_CONFINEMENT_STRICT)
+
+       confinement = snapd_snap_get_confinement (snap);
+       enum_class = g_type_class_ref (SNAPD_TYPE_CONFINEMENT);
+       gs_app_set_metadata (app, "snap::confinement", g_enum_get_value (enum_class, 
confinement)->value_nick);
+       g_type_class_unref (enum_class);
+
+       if (priv->system_confinement == SNAPD_SYSTEM_CONFINEMENT_STRICT && confinement == 
SNAPD_CONFINEMENT_STRICT)
                gs_app_add_kudo (app, GS_APP_KUDO_SANDBOXED);
 
        return app;
@@ -735,13 +743,16 @@ gs_plugin_app_install (GsPlugin *plugin,
                       GError **error)
 {
        GsPluginData *priv = gs_plugin_get_data (plugin);
+       SnapdInstallFlags flags = SNAPD_INSTALL_FLAGS_NONE;
 
        /* We can only install apps we know of */
        if (g_strcmp0 (gs_app_get_management_plugin (app), "snap") != 0)
                return TRUE;
 
        gs_app_set_state (app, AS_APP_STATE_INSTALLING);
-       if (!snapd_client_install2_sync (priv->client, SNAPD_INSTALL_FLAGS_NONE, gs_app_get_id (app), NULL, 
NULL, progress_cb, app, cancellable, error)) {
+       if (g_strcmp0 (gs_app_get_metadata_item (app, "snap::confinement"), "classic") == 0)
+               flags |= SNAPD_INSTALL_FLAGS_CLASSIC;
+       if (!snapd_client_install2_sync (priv->client, flags, gs_app_get_id (app), NULL, NULL, progress_cb, 
app, cancellable, error)) {
                gs_app_set_state_recover (app);
                snapd_error_convert (error);
                return FALSE;