[sysadmin-bin] Missing enclosing parenthesis on the if statement. Also drop the cd against GIT_DIR, that is the wor



commit 314e0b516ddd87f0ed17f6cedce728fe5a894614
Author: Andrea Veri <averi redhat com>
Date:   Fri Dec 1 14:21:31 2017 +0100

    Missing enclosing parenthesis on the if statement. Also drop the cd against GIT_DIR, that is the working 
directory by default. The setfacls calls are staying where they are now as any eventual pre-receive hook 
rejected commit writes an object on disk. The respective commit is marked as dangling and will be purged by 
git gc (ran on gitlab.g.o via the git user)

 git/gnome-pre-receive |    4 +---
 1 files changed, 1 insertions(+), 3 deletions(-)
---
diff --git a/git/gnome-pre-receive b/git/gnome-pre-receive
index 1b8dc52..ad5fe43 100755
--- a/git/gnome-pre-receive
+++ b/git/gnome-pre-receive
@@ -65,7 +65,6 @@ fi
 
 if [ $(hostname) == 'gitlab.gnome.org' ]; then
   if [ $basedir = '/var/opt/gitlab/git-data/repositories/GNOME' ]; then
-    cd $GIT_DIR
     git config hooks.emailprefix 1>/dev/null
     if [ "$?" -eq 1 ]; then
       git config hooks.emailprefix ""
@@ -87,7 +86,6 @@ if [ $(hostname) == 'gitlab.gnome.org' ]; then
     setfacl -R -m g:gnomecvs:rwx $GIT_DIR
   fi
 elif [ $(hostname) == 'git.gnome.org' ]; then
-  cd $GIT_DIR
   if `git config gnome.gitlabrepo`; then
     user=`id -u`
     find $GIT_DIR/objects -uid $user -type d | xargs setfacl -d -m g:git:rwx
@@ -95,7 +93,7 @@ elif [ $(hostname) == 'git.gnome.org' ]; then
     find $GIT_DIR/refs/heads -uid $user -type d | xargs setfacl -d -m g:git:rwx
     find $GIT_DIR/refs/heads -uid $user | xargs setfacl -m g:git:rwx
 
-    if $user == 8033; then
+    if [ $user == 8033 ]; then
         :
     else
         cat <<EOF 1>&2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]