[gnome-continuous-yocto/gnomeostree-3.28-rocko: 1042/8267] bitbake.conf: don't set CCACHE_DIR to $HOME by default

[Emmanuele Bassi <ebassi src gnome org>]

commit 95cd78a7b5861f8ef10f419ba336439c50fda9ab
Author: Ross Burton <ross burton intel com>
Date:   Mon Jun 20 13:13:09 2016 +0100

    bitbake.conf: don't set CCACHE_DIR to $HOME by default
    
    If the user hasn't inherited ccache.bbclass then CCACHE_DIR is set to $HOME.
    
    This was to work around a bug (#2554) for some users where if ccache < 3.1.10
    (released 2014-10-19) was installed and enabled by default (i.e. /usr/bin/gcc is
    a symlink to ccache) and ccache.bbclass wasn't being inherited then autogen
    would fail to build because it sets $HOME to /dev/null during the build and
    ccache (prior to 3.1.10) would always create CCACHE_DIR even if it was disabled.
    As the default is $HOME/.ccache, this results in ccache attempting to create
    /dev/null/.ccache.
    
    However there was a mistake in this assignment of CCACHE_DIR - it should be
    $HOME/.ccache - as ccache will do cleanup inside CCACHE_DIR which will result in
    it deleting $HOME/tmp.  In the future when we can assume that everyone has
    ccache 3.1.10 onwards this assignment can be deleted, but as of now we still
    support OpenSUSE 13.2 which ships with 3.1.9 so fix the assignment to be
    $HOME/.ccache.
    
    [ YOCTO #9798 ]
    
    (From OE-Core rev: 15eaf9cb1fa19036fe4442905876dae94070b04d)
    
    Signed-off-by: Ross Burton <ross burton intel com>
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 meta/conf/bitbake.conf |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/meta/conf/bitbake.conf b/meta/conf/bitbake.conf
index 942b8b1..a72d2f6 100644
--- a/meta/conf/bitbake.conf
+++ b/meta/conf/bitbake.conf
@@ -450,10 +450,10 @@ CCACHE ??= ""
 # Disable ccache explicitly if CCACHE is null since gcc may be a symlink
 # of ccache some distributions (e.g., Fedora 17).
 export CCACHE_DISABLE ??= "${@[0,1][d.getVar('CCACHE', True) == '']}"
-# Assign CCACHE_DIR a default value to fix a bug of ccache 3.1.7,
-# since it would always create CCACHE_DIR/.ccache even if
-# CCACHE_DISABLE = 1.
-export CCACHE_DIR ??= "${@os.getenv('HOME')}"
+# ccache < 3.1.10 will create CCACHE_DIR on startup even if disabled, and
+# autogen sets HOME=/dev/null so in certain situations builds can fail.
+# Explicitly export CCACHE_DIR until we can assume ccache >3.1.10 on the host.
+export CCACHE_DIR ??= "${@os.getenv('HOME')}/.ccache"
 
 TOOLCHAIN_OPTIONS = " --sysroot=${STAGING_DIR_TARGET}"