[gnome-continuous-yocto/gnomeostree-3.28-rocko: 5381/8267] bitbake: tinfoil: fix get_recipe_file() to return an error on invalid recipe
- From: Emmanuele Bassi <ebassi src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-continuous-yocto/gnomeostree-3.28-rocko: 5381/8267] bitbake: tinfoil: fix get_recipe_file() to return an error on invalid recipe
- Date: Sun, 17 Dec 2017 03:21:37 +0000 (UTC)
commit c2ac78c4d8fb6aa85a6787cf170ea7f06659d2eb
Author: Paul Eggleton <paul eggleton linux intel com>
Date: Thu Mar 30 15:23:59 2017 +1300
bitbake: tinfoil: fix get_recipe_file() to return an error on invalid recipe
This function calls cooker.findBestProvider() but didn't handle the fact
that that function returns a tuple (None, None, None, None) when there
is no matching recipe. (This fixes devtool in OpenEmbedded showing a
traceback when an invalid recipe is specified instead of a proper error
message.)
(Bitbake rev: 54a4757ca706afc6e98c7692f960592e80cab12b)
Signed-off-by: Paul Eggleton <paul eggleton linux intel com>
Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>
bitbake/lib/bb/tinfoil.py | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/bitbake/lib/bb/tinfoil.py b/bitbake/lib/bb/tinfoil.py
index c2ee707..14a2271 100644
--- a/bitbake/lib/bb/tinfoil.py
+++ b/bitbake/lib/bb/tinfoil.py
@@ -363,7 +363,7 @@ class Tinfoil:
skipped.
"""
best = self.find_best_provider(pn)
- if not best:
+ if not best or (len(best) > 3 and not best[3]):
skiplist = self.get_skipped_recipes()
taskdata = bb.taskdata.TaskData(None, skiplist=skiplist)
skipreasons = taskdata.get_reasons(pn)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]