[gnome-continuous-yocto/gnomeostree-3.28-rocko: 6247/8267] native/nativesdk: Ensure DISTRO_FEATURES is determistic
- From: Emmanuele Bassi <ebassi src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-continuous-yocto/gnomeostree-3.28-rocko: 6247/8267] native/nativesdk: Ensure DISTRO_FEATURES is determistic
- Date: Sun, 17 Dec 2017 04:34:37 +0000 (UTC)
commit 437f9cdbaf082974a2a0c1d17e1010b6fab9fe91
Author: Richard Purdie <richard purdie linuxfoundation org>
Date: Mon Jun 12 11:03:55 2017 +0100
native/nativesdk: Ensure DISTRO_FEATURES is determistic
set() order is random and hence the filtered native/nativesdk DISTRO_FEATURES
could be set to random ordering. We've been lucky so far this tended not to
cause issues but some queued changes highedlighted this. Thrown in a sorted()
so the order is deterministic and we get consistent hash checksums between runs
and between machines.
(From OE-Core rev: 76391673754cf6a01d68eedbd4181e543fa2f427)
Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>
meta/classes/native.bbclass | 2 +-
meta/classes/nativesdk.bbclass | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/meta/classes/native.bbclass b/meta/classes/native.bbclass
index b8f839a..6b7f3dd 100644
--- a/meta/classes/native.bbclass
+++ b/meta/classes/native.bbclass
@@ -129,7 +129,7 @@ python native_virtclass_handler () {
# from modifying native distro features
features = set(d.getVar("DISTRO_FEATURES_NATIVE").split())
filtered = set(bb.utils.filter("DISTRO_FEATURES", d.getVar("DISTRO_FEATURES_FILTER_NATIVE"), d).split())
- d.setVar("DISTRO_FEATURES", " ".join(features | filtered))
+ d.setVar("DISTRO_FEATURES", " ".join(sorted(features | filtered)))
classextend = e.data.getVar('BBCLASSEXTEND') or ""
if "native" not in classextend:
diff --git a/meta/classes/nativesdk.bbclass b/meta/classes/nativesdk.bbclass
index 655b456..69fb45c 100644
--- a/meta/classes/nativesdk.bbclass
+++ b/meta/classes/nativesdk.bbclass
@@ -74,7 +74,7 @@ python nativesdk_virtclass_handler () {
# from modifying nativesdk distro features
features = set(d.getVar("DISTRO_FEATURES_NATIVESDK").split())
filtered = set(bb.utils.filter("DISTRO_FEATURES", d.getVar("DISTRO_FEATURES_FILTER_NATIVESDK"),
d).split())
- d.setVar("DISTRO_FEATURES", " ".join(features | filtered))
+ d.setVar("DISTRO_FEATURES", " ".join(sorted(features | filtered)))
e.data.setVar("MLPREFIX", "nativesdk-")
e.data.setVar("PN", "nativesdk-" + e.data.getVar("PN").replace("-nativesdk", "").replace("nativesdk-",
""))
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]