[gnome-continuous-yocto/gnomeostree-3.28-rocko: 8049/8267] cmake: fix typo in toolchain file



commit d1f30d37ba38b2a03fc5eb4fd13af4ea5bd8307f
Author: Øystein Walle <ow datarespons no>
Date:   Tue Oct 10 14:59:40 2017 +0200

    cmake: fix typo in toolchain file
    
    The missing underscore makes CMake define a new variable named "CMAKE"
    with the contents "ASM_FLAGS ${CMAKE_C_FLAGS}" instead of a variable
    named "CMAKE_ASM_FLAGS" with contents equal to "CMAKE_C_FLAGS". It seems
    clear that the intention was to assign "CMAKE_ASM_FLAGS".
    
    CMake uses variables named "CMAKE_<LANG>_FLAGS" for defining default
    compiler flags for a given language <LANG>. Leaving this flag unset may
    have unintended consequences. Not doing so is however not an error as
    far as CMake is concerned so it is silently accepted.
    
    (From OE-Core rev: 03a4dd085e3be2821eff5a1a1e7e96b809465565)
    
    Signed-off-by: Øystein Walle <ow datarespons no>
    Signed-off-by: Ross Burton <ross burton intel com>
    Signed-off-by: Richard Purdie <richard purdie linuxfoundation org>

 .../cmake/cmake/OEToolchainConfig.cmake            |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
---
diff --git a/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake 
b/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
index 6518408..dc8477e 100644
--- a/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
+++ b/meta/recipes-devtools/cmake/cmake/OEToolchainConfig.cmake
@@ -1,7 +1,7 @@
 set( CMAKE_SYSTEM_NAME Linux )
 set( CMAKE_C_FLAGS $ENV{CFLAGS} CACHE STRING "" FORCE )
 set( CMAKE_CXX_FLAGS $ENV{CXXFLAGS}  CACHE STRING "" FORCE )
-set( CMAKE ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
+set( CMAKE_ASM_FLAGS ${CMAKE_C_FLAGS} CACHE STRING "" FORCE )
 set( CMAKE_LDFLAGS_FLAGS ${CMAKE_CXX_FLAGS} CACHE STRING "" FORCE )
 
 set( CMAKE_FIND_ROOT_PATH $ENV{OECORE_TARGET_SYSROOT} $ENV{OECORE_NATIVE_SYSROOT} )


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]