[gnome-music/wip/mschraal/readme] Update README.md
- From: Marinus Schraal <mschraal src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-music/wip/mschraal/readme] Update README.md
- Date: Tue, 19 Dec 2017 08:17:33 +0000 (UTC)
commit 2b499ce18d72c205a3c3982df90d47d359bd5de2
Author: Marinus Schraal <fosero+gnome gmail com>
Date: Tue Dec 19 08:17:23 2017 +0000
Update README.md
README.md | 73 +++++++++++++++++++++++++++++++++++++++++++++++++++++++--------
1 file changed, 64 insertions(+), 9 deletions(-)
---
diff --git a/README.md b/README.md
index 6c4e3d9..c99983c 100644
--- a/README.md
+++ b/README.md
@@ -3,26 +3,81 @@ Music is the new GNOME music playing application.
# Where can I find more?
-We have a wiki page at
-https://wiki.gnome.org/Apps/Music
+Music has a wiki page at
+https://wiki.gnome.org/Apps/Music (outdated).
-You can join us on the IRC:
-#gnome-music on GIMPNet
+You can join the developers on IRC: #gnome-music on
[GIMPNet](https://wiki.gnome.org/Community/GettingInTouch/IRC).
# Join the development
-Follow the guide at https://wiki.gnome.org/Newcomers/ and choose Music as your project.
+Follow the guide at https://wiki.gnome.org/Newcomers/ and choose Music as your project. There are bugs
labeled for newcomers, which should provide an easy entry point. Of course, feel free to pick something more
challenging. Pick bugs if you can, the goal is to make the current Music experience sound & stable and only
then extend it's functionality.
# Coding style
GNOME Music is written in Python and aspires to adhere to the coding style described in the python style
guide [PEP-8](https://www.python.org/dev/peps/pep-0008/).
-Use of docstrings is recommended following [PEP-257](https://www.python.org/dev/peps/pep-0257/).
+Since Music was written over many years and by many different contributors without a single style being
enforced, it currently is in a mixed style state. The goal is to eventually consistently follow
[PEP-8](https://www.python.org/dev/peps/pep-0008/) for style and
[PEP-257](https://www.python.org/dev/peps/pep-0257/) for docstrings. The content of docstrings uses the
[Sphinx markup style](http://www.sphinx-doc.org/).
-The content of docstrings uses the [Sphinx markup style](http://www.sphinx-doc.org/).
+Docstrings should be added to all (new) public functions.
-Use PyGI shorthands for manipulating GtkTreeModel:
+Since looking at the surrounding code might give mixed results, take note of the following rules as a basic
style guide.
+
+### Line length
+>>>
+Limit all lines to a maximum of 79 characters.
+
+For flowing long blocks of text with fewer structural restrictions (docstrings or comments), the line length
should be limited to 72 characters.
+>>>
+
+### Indentation
+Music uses hanging indents when the lines get too long.
+>>>
+When using a hanging indent the following should be considered; there should be no arguments on the first
line and further indentation should be used to clearly distinguish itself as a continuation line.
+>>>
+
+```python
+# More indentation included to distinguish this from the rest.
+def long_function_name(
+ var_one, var_two, var_three,
+ var_four):
+ print(var_one)
+
+
+# Hanging indents should add a level.
+foo = long_function_name(
+ var_one, var_two,
+ var_three, var_four)
+```
+
+### Line break before a binary operator
+```python
+
+# Yes: easy to match operators with operands
+income = (gross_wages
+ + taxable_interest
+ + (dividends - qualified_dividends)
+ - ira_deduction
+ - student_loan_interest)
+
+# Add some extra indentation on the conditional continuation line.
+if (this_is_one_thing
+ and that_is_another_thing):
+ do_something()
+```
+
+### Class internals
+
+All non-public classwide variables or methods should be prepended with an underscore.
+
+>>>
+_single_leading_underscore: weak "internal use" indicator. E.g. from M import * does not import objects
whose name starts with an underscore.
+>>>
+
+### PyGI specific
+
+Use PyGI shorthands for manipulating `GtkTreeModel` & `GtkListStore`:
```python
model[iter][0] = "artist"
-artist, title = model[iter][1, 4]```
\ No newline at end of file
+artist, title = model[iter][1, 4]
+```
\ No newline at end of file
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]