[epiphany] bookmark: include tag name in tag-added signal
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany] bookmark: include tag name in tag-added signal
- Date: Sun, 22 Jan 2017 17:51:29 +0000 (UTC)
commit 3e4768e292745685963e37ed57ff7963dc89359f
Author: Michael Catanzaro <mcatanzaro gnome org>
Date: Sun Jan 22 11:08:40 2017 -0600
bookmark: include tag name in tag-added signal
Even though it's not currently used, it's pretty strange to have a
tag-added signal that doesn't indicate which tag was added. This changes
the signal to parallel tag-removed.
src/bookmarks/ephy-bookmark.c | 5 +++--
src/bookmarks/ephy-bookmarks-popover.c | 1 +
2 files changed, 4 insertions(+), 2 deletions(-)
---
diff --git a/src/bookmarks/ephy-bookmark.c b/src/bookmarks/ephy-bookmark.c
index 75d3ca6..f42f732 100644
--- a/src/bookmarks/ephy-bookmark.c
+++ b/src/bookmarks/ephy-bookmark.c
@@ -188,7 +188,8 @@ ephy_bookmark_class_init (EphyBookmarkClass *klass)
G_SIGNAL_RUN_LAST,
0,
NULL, NULL, NULL,
- G_TYPE_NONE, 0);
+ G_TYPE_NONE, 1,
+ G_TYPE_STRING);
signals[TAG_REMOVED] =
g_signal_new ("tag-removed",
@@ -441,7 +442,7 @@ ephy_bookmark_add_tag (EphyBookmark *self,
|| g_strcmp0 (g_sequence_get (prev_tag_iter), tag) != 0)
g_sequence_insert_before (tag_iter, g_strdup (tag));
- g_signal_emit (self, signals[TAG_ADDED], 0);
+ g_signal_emit (self, signals[TAG_ADDED], 0, tag);
}
void
diff --git a/src/bookmarks/ephy-bookmarks-popover.c b/src/bookmarks/ephy-bookmarks-popover.c
index cfdb7f2..bcd59c8 100644
--- a/src/bookmarks/ephy-bookmarks-popover.c
+++ b/src/bookmarks/ephy-bookmarks-popover.c
@@ -63,6 +63,7 @@ static GtkWidget *create_bookmark_row (gpointer item, gpointer user_data);
static void
bookmark_tag_added_cb (EphyBookmark *bookmark,
+ const char *tag,
EphyBookmarksPopover *popover)
{
g_assert (EPHY_IS_BOOKMARK (bookmark));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]