[gimp] app: fix leaks when freeing the list of accum_buffers in gimpsmudge.c
- From: Michael Natterer <mitch src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] app: fix leaks when freeing the list of accum_buffers in gimpsmudge.c
- Date: Sat, 15 Jul 2017 16:43:39 +0000 (UTC)
commit f3561549bb3cbcb923fc87be761b949f41f3db0f
Author: Michael Natterer <mitch gimp org>
Date: Sat Jul 15 18:36:53 2017 +0200
app: fix leaks when freeing the list of accum_buffers in gimpsmudge.c
app/paint/gimpsmudge.c | 16 ++++++++++++----
1 files changed, 12 insertions(+), 4 deletions(-)
---
diff --git a/app/paint/gimpsmudge.c b/app/paint/gimpsmudge.c
index e068ff1..5a1d8d4 100644
--- a/app/paint/gimpsmudge.c
+++ b/app/paint/gimpsmudge.c
@@ -97,8 +97,8 @@ gimp_smudge_class_init (GimpSmudgeClass *klass)
paint_core_class->paint = gimp_smudge_paint;
- brush_core_class->handles_changing_brush = TRUE;
- brush_core_class->handles_transforming_brush = TRUE;
+ brush_core_class->handles_changing_brush = TRUE;
+ brush_core_class->handles_transforming_brush = TRUE;
brush_core_class->handles_dynamic_transforming_brush = TRUE;
}
@@ -120,8 +120,10 @@ gimp_smudge_finalize (GObject *object)
{
if (iter->data)
g_object_unref (iter->data);
- smudge->accum_buffers = NULL;
}
+
+ g_list_free (smudge->accum_buffers);
+ smudge->accum_buffers = NULL;
}
G_OBJECT_CLASS (parent_class)->finalize (object);
@@ -158,9 +160,12 @@ gimp_smudge_paint (GimpPaintCore *paint_core,
{
if (iter->data)
g_object_unref (iter->data);
- smudge->accum_buffers = NULL;
}
+
+ g_list_free (smudge->accum_buffers);
+ smudge->accum_buffers = NULL;
}
+
smudge->initialized = FALSE;
break;
@@ -260,6 +265,7 @@ gimp_smudge_start (GimpPaintCore *paint_core,
paint_buffer_y - y,
0, 0));
}
+
smudge->accum_buffers = g_list_reverse (smudge->accum_buffers);
return TRUE;
@@ -355,6 +361,7 @@ gimp_smudge_motion (GimpPaintCore *paint_core,
*/
accum_buffer = g_list_nth_data (smudge->accum_buffers, i);
+
gimp_gegl_smudge_blend (accum_buffer,
GEGL_RECTANGLE (paint_buffer_x - x,
paint_buffer_y - y,
@@ -411,6 +418,7 @@ gimp_smudge_accumulator_coords (GimpPaintCore *paint_core,
GeglBuffer *accum_buffer;
accum_buffer = g_list_nth_data (smudge->accum_buffers, stroke);
+
*x = (gint) coords->x - gegl_buffer_get_width (accum_buffer) / 2;
*y = (gint) coords->y - gegl_buffer_get_height (accum_buffer) / 2;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]