[gnome-software] packagekit: Don't explicitly disable PackageKit interactivity

[Robert Ancell <rancell src gnome org>]

commit 8ecc6713380cd6922adfc2892d8282891eedf3ec
Author: Robert Ancell <robert ancell canonical com>
Date:   Thu May 18 09:10:51 2017 +1200

    packagekit: Don't explicitly disable PackageKit interactivity
    
    We need interactivity for debconf prompts to install when installing .debs.
    This is not most packages (i.e. not normally apps) but some dependencies can
    trigger debconf prompts. If PackageKit is set to be non-interactive then
    these packages never complete installation and the user is left confused.
    The default PackageKit behaviour is to allow interactivity.
    
    https://mail.gnome.org/archives/gnome-software-list/2017-May/msg00011.html

 plugins/packagekit/gs-plugin-packagekit-local.c   |    1 -
 plugins/packagekit/gs-plugin-packagekit-refine.c  |    1 -
 plugins/packagekit/gs-plugin-packagekit-refresh.c |    1 -
 plugins/packagekit/gs-plugin-packagekit-upgrade.c |    1 -
 plugins/packagekit/gs-plugin-packagekit.c         |    1 -
 5 files changed, 0 insertions(+), 5 deletions(-)
---
diff --git a/plugins/packagekit/gs-plugin-packagekit-local.c b/plugins/packagekit/gs-plugin-packagekit-local.c
index 46df5ea..0840b12 100644
--- a/plugins/packagekit/gs-plugin-packagekit-local.c
+++ b/plugins/packagekit/gs-plugin-packagekit-local.c
@@ -38,7 +38,6 @@ gs_plugin_initialize (GsPlugin *plugin)
        GsPluginData *priv = gs_plugin_alloc_data (plugin, sizeof(GsPluginData));
        priv->task = pk_task_new ();
        pk_client_set_background (PK_CLIENT (priv->task), FALSE);
-       pk_client_set_interactive (PK_CLIENT (priv->task), FALSE);
 }
 
 void
diff --git a/plugins/packagekit/gs-plugin-packagekit-refine.c 
b/plugins/packagekit/gs-plugin-packagekit-refine.c
index 341a154..a94f3b2 100644
--- a/plugins/packagekit/gs-plugin-packagekit-refine.c
+++ b/plugins/packagekit/gs-plugin-packagekit-refine.c
@@ -60,7 +60,6 @@ gs_plugin_initialize (GsPlugin *plugin)
        g_signal_connect (priv->control, "repo-list-changed",
                          G_CALLBACK (gs_plugin_packagekit_cache_invalid_cb), plugin);
        pk_client_set_background (priv->client, FALSE);
-       pk_client_set_interactive (priv->client, FALSE);
        pk_client_set_cache_age (priv->client, G_MAXUINT);
 
        /* we can get better results than the RPM plugin */
diff --git a/plugins/packagekit/gs-plugin-packagekit-refresh.c 
b/plugins/packagekit/gs-plugin-packagekit-refresh.c
index a0377d0..4006444 100644
--- a/plugins/packagekit/gs-plugin-packagekit-refresh.c
+++ b/plugins/packagekit/gs-plugin-packagekit-refresh.c
@@ -43,7 +43,6 @@ gs_plugin_initialize (GsPlugin *plugin)
        priv->task = pk_task_new ();
        pk_task_set_only_download (priv->task, TRUE);
        pk_client_set_background (PK_CLIENT (priv->task), TRUE);
-       pk_client_set_interactive (PK_CLIENT (priv->task), FALSE);
 
        /* we can return better results than dpkg directly */
        gs_plugin_add_rule (plugin, GS_PLUGIN_RULE_CONFLICTS, "dpkg");
diff --git a/plugins/packagekit/gs-plugin-packagekit-upgrade.c 
b/plugins/packagekit/gs-plugin-packagekit-upgrade.c
index 6791efc..e119389 100644
--- a/plugins/packagekit/gs-plugin-packagekit-upgrade.c
+++ b/plugins/packagekit/gs-plugin-packagekit-upgrade.c
@@ -39,7 +39,6 @@ gs_plugin_initialize (GsPlugin *plugin)
        pk_task_set_only_download (priv->task, TRUE);
        pk_client_set_background (PK_CLIENT (priv->task), TRUE);
        pk_client_set_cache_age (PK_CLIENT (priv->task), 60 * 60 * 24);
-       pk_client_set_interactive (PK_CLIENT (priv->task), FALSE);
 }
 
 void
diff --git a/plugins/packagekit/gs-plugin-packagekit.c b/plugins/packagekit/gs-plugin-packagekit.c
index 460e41f..3b37359 100644
--- a/plugins/packagekit/gs-plugin-packagekit.c
+++ b/plugins/packagekit/gs-plugin-packagekit.c
@@ -46,7 +46,6 @@ gs_plugin_initialize (GsPlugin *plugin)
        GsPluginData *priv = gs_plugin_alloc_data (plugin, sizeof(GsPluginData));
        priv->task = pk_task_new ();
        pk_client_set_background (PK_CLIENT (priv->task), FALSE);
-       pk_client_set_interactive (PK_CLIENT (priv->task), FALSE);
        pk_client_set_cache_age (PK_CLIENT (priv->task), G_MAXUINT);
 }