[smuxi: 150/179] Engine-XMPP: remove obsolete Facebook protocol manager
- From: Mirco M. M. Bauer <mmmbauer src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [smuxi: 150/179] Engine-XMPP: remove obsolete Facebook protocol manager
- Date: Sat, 4 Nov 2017 05:50:18 +0000 (UTC)
commit aada6238b4655a31773dfe649ca020f83f3e8ca7
Author: Mirco Bauer <meebey meebey net>
Date: Mon May 29 20:44:39 2017 +0800
Engine-XMPP: remove obsolete Facebook protocol manager
Facebook has killed their XMPP gateway [0] since April 30th, 2015. Since then
it is no longer possible to connect to Facebook using XMPP and this confuses
sometimes Smuxi users as Facebook is still shown as a protocol option.
If Facebook ever changes their mind on this, this code can be easily brought
back if needed.
[0]: https://developers.facebook.com/docs/chat
src/Engine-XMPP/Engine-XMPP.csproj | 3 -
src/Engine-XMPP/Makefile.am | 3 +-
.../Protocols/Xmpp/FacebookProtocolManager.cs | 47 --------------------
.../Protocols/Xmpp/XmppProtocolManager.cs | 8 ---
4 files changed, 1 insertions(+), 60 deletions(-)
---
diff --git a/src/Engine-XMPP/Engine-XMPP.csproj b/src/Engine-XMPP/Engine-XMPP.csproj
index ace11c6..0e81210 100644
--- a/src/Engine-XMPP/Engine-XMPP.csproj
+++ b/src/Engine-XMPP/Engine-XMPP.csproj
@@ -47,9 +47,6 @@
<Compile Include="Config\XmppPersonModel.cs" />
</ItemGroup>
<ItemGroup>
- <Compile Include="Protocols\Xmpp\FacebookProtocolManager.cs" />
- </ItemGroup>
- <ItemGroup>
<ProjectReference Include="..\Common\Common.csproj">
<Project>{73DEF91D-03FF-41E3-B2E1-3259AF247CA7}</Project>
<Name>Common</Name>
diff --git a/src/Engine-XMPP/Makefile.am b/src/Engine-XMPP/Makefile.am
index c8b02db..f66ee97 100644
--- a/src/Engine-XMPP/Makefile.am
+++ b/src/Engine-XMPP/Makefile.am
@@ -9,8 +9,7 @@ SOURCES = \
Config/XmppServerModel.cs \
Protocols/Xmpp/XmppGroupChatModel.cs \
Protocols/Xmpp/XmppProtocolManager.cs \
- Config/XmppPersonModel.cs \
- Protocols/Xmpp/FacebookProtocolManager.cs
+ Config/XmppPersonModel.cs
REFERENCES = \
System \
diff --git a/src/Engine-XMPP/Protocols/Xmpp/XmppProtocolManager.cs
b/src/Engine-XMPP/Protocols/Xmpp/XmppProtocolManager.cs
index fb703cb..b0c772c 100644
--- a/src/Engine-XMPP/Protocols/Xmpp/XmppProtocolManager.cs
+++ b/src/Engine-XMPP/Protocols/Xmpp/XmppProtocolManager.cs
@@ -253,14 +253,6 @@ namespace Smuxi.Engine
NetworkID, String.Format("{0} {1}", Protocol, Host), this
);
Session.AddChat(NetworkChat);
- if (Host.EndsWith("facebook.com") && !(this is FacebookProtocolManager)) {
- var builder = CreateMessageBuilder();
- builder.AppendEventPrefix();
- builder.AppendMessage(_("This engine has native Facebook support, you should be using it
instead of connecting to Facebook with XMPP"));
- // cannot use AddMessageToFrontend because NetworkChat is not yet synced, causing
AddMessageToFrontend to drop it.
- // cannot sync NetworkChat before this, because then the sync would swallow the message
- Session.AddMessageToChat(NetworkChat, builder.ToMessage());
- }
Session.SyncChat(NetworkChat);
Connect();
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]