[meld] filediff: Fix overly eager tab close handling for cancelled	closes
- From: Kai Willadsen <kaiw src gnome org>
 
- To: commits-list gnome org
 
- Cc: 
 
- Subject: [meld] filediff: Fix overly eager tab close handling for cancelled	closes
 
- Date: Sun, 19 Nov 2017 01:09:28 +0000 (UTC)
 
commit 1ddd9fbc3cd3757347c8a06c9201a630ea2f2b38
Author: Kai Willadsen <kai willadsen gmail com>
Date:   Sun Nov 19 10:41:26 2017 +1000
    filediff: Fix overly eager tab close handling for cancelled closes
 meld/filediff.py |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
---
diff --git a/meld/filediff.py b/meld/filediff.py
index 2301577..6ca514c 100644
--- a/meld/filediff.py
+++ b/meld/filediff.py
@@ -851,14 +851,14 @@ class FileDiff(melddoc.MeldDoc, gnomeglade.Component):
         return response
 
     def on_delete_event(self):
-        # TODO: This should not be necessary; remove if and when we
-        # figure out what's keeping MeldDocs alive for too long.
-        del self._cached_match
         self.state = melddoc.STATE_CLOSING
         response = self.check_save_modified()
         if response == Gtk.ResponseType.OK:
             for h in self.settings_handlers:
                 meldsettings.disconnect(h)
+            # TODO: This should not be necessary; remove if and when we
+            # figure out what's keeping MeldDocs alive for too long.
+            del self._cached_match
             # TODO: Base the return code on something meaningful for VC tools
             self.emit('close', 0)
         return response
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]