[gjs: 1/2] CI: small tweaks

[Philip Chimento <pchimento src gnome org>]

commit 9a647765914d9c7aad6104aa10bafa8f222d5492
Author: Claudio André <claudioandre br gmail com>
Date:   Mon Apr 16 16:35:09 2018 -0300

    CI: small tweaks
    
    - Create a job that is pinned on purpose;
    - Shrink the stages;
    - Rename the first stage to reflect what it is doing.

 .gitlab-ci.yml | 36 ++++++++++++++++++++++--------------
 1 file changed, 22 insertions(+), 14 deletions(-)
---
diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index b9601c08..dc130e3f 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -2,9 +2,8 @@ services:
   - docker
 
 stages:
-- static_analysis
+- source_check
 - test
-- build
 - thorough_tests
 - docs
 
@@ -65,20 +64,24 @@ stages:
        echo "***             See you soon              ***";
        echo "*********************************************";
     '
-
+#############################################
+# Able to test despite of any Docker image changes
+#############################################
 fedora:
   <<: *build
-  when: always
-  stage: test
-  image: claudioandre/spidermonkey:job-400.5  # temporarily pinned to old tag
+  stage: source_check
+  image: claudioandre/spidermonkey:job-400.5  # pinned on purpose
   variables:
     CC: gcc
     DEV: devel
     TEST: "check"
 
+#############################################
+# Regular tests
+#############################################
 ubuntu_gcc:
   <<: *build
-  stage: build
+  stage: test
   image: claudioandre/spidermonkey:ubuntu.dev.gcc
   variables:
     CC: gcc
@@ -89,7 +92,7 @@ ubuntu_gcc:
 
 ubuntu_clang:
   <<: *build
-  stage: build
+  stage: test
   image: claudioandre/spidermonkey:ubuntu.dev.gcc
   variables:
     CC: clang
@@ -100,7 +103,7 @@ ubuntu_clang:
 
 fedora_clang:
   <<: *build
-  stage: build
+  stage: test
   image: claudioandre/spidermonkey:new-342.4  # temporarily pinned to old tag
   variables:
     CC: clang
@@ -174,37 +177,42 @@ codequality:
   only:
     - master@GNOME/gjs
 
+#############################################
+# Static Analyzers
+#############################################
 cppcheck:
   <<: *build
-  stage: static_analysis
+  stage: source_check
   image: claudioandre/spidermonkey:fedora.static.analysis
   variables:
     CODECHECK: "CPPCHECK"
 
 cpplint:
   <<: *build
-  stage: static_analysis
+  stage: source_check
   image: claudioandre/spidermonkey:fedora.static.analysis
   variables:
     CODECHECK: "CPPLINT"
 
 eslint:
   <<: *build
-  stage: static_analysis
+  stage: source_check
   image: claudioandre/spidermonkey:fedora.static.analysis
   variables:
     CODECHECK: "ESLINT"
 
 code_statistics:
   <<: *build
-  stage: static_analysis
+  stage: source_check
   image: claudioandre/spidermonkey:fedora.static.analysis
   variables:
     CODECHECK: "TOKEI"
   only:
     - master@GNOME/gjs
 
-# Publish Code Coverage Report
+#############################################
+# Publish the Code Coverage Report
+#############################################
 pages:
   stage: docs
   dependencies: