[libsoup/gnome-3-28] soup-socket: fix critical warning when the peer-certificate changes after disconnect
- From: Carlos Garcia Campos <carlosgc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [libsoup/gnome-3-28] soup-socket: fix critical warning when the peer-certificate changes after disconnect
- Date: Fri, 20 Apr 2018 10:21:18 +0000 (UTC)
commit 703b9eb0760e3d7d4e1a87ad79812258ca7d4960
Author: Carlos Garcia Campos <cgarcia igalia com>
Date: Fri Apr 20 12:14:55 2018 +0200
soup-socket: fix critical warning when the peer-certificate changes after disconnect
(process:15586): GLib-GIO-CRITICAL **: 12:14:39.627: g_tls_connection_get_peer_certificate_errors:
assertion 'G_IS_TLS_CONNECTION (conn)' failed
We should disconnect the signal on disconnect_internal before clearing
the connection object.
libsoup/soup-socket.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
---
diff --git a/libsoup/soup-socket.c b/libsoup/soup-socket.c
index 5363dc7..311c627 100644
--- a/libsoup/soup-socket.c
+++ b/libsoup/soup-socket.c
@@ -188,6 +188,7 @@ disconnect_internal (SoupSocket *sock, gboolean close)
g_clear_object (&priv->gsock);
if (priv->conn && close) {
g_io_stream_close (priv->conn, NULL, NULL);
+ g_signal_handlers_disconnect_by_data (priv->conn, sock);
g_clear_object (&priv->conn);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]