[amtk] Write more notes for future maintainers
- From: Sébastien Wilmet <swilmet src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [amtk] Write more notes for future maintainers
- Date: Sun, 12 Aug 2018 10:49:30 +0000 (UTC)
commit 3d0813c7f1d2579cb8bfed5ea2c0683a0703254c
Author: Sébastien Wilmet <swilmet gnome org>
Date: Sun Aug 12 12:43:44 2018 +0200
Write more notes for future maintainers
HACKING | 2 ++
amtk/NOTES | 13 +++++++++++--
2 files changed, 13 insertions(+), 2 deletions(-)
---
diff --git a/HACKING b/HACKING
index dd870f9..4e6a0bf 100644
--- a/HACKING
+++ b/HACKING
@@ -8,3 +8,5 @@ Amtk follows the same guidelines and code conventions as GtkSourceView:
The Amtk GitLab:
https://gitlab.gnome.org/GNOME/amtk
+
+See also the amtk/NOTES file.
diff --git a/amtk/NOTES b/amtk/NOTES
index 602aa3d..8f003c2 100644
--- a/amtk/NOTES
+++ b/amtk/NOTES
@@ -4,8 +4,15 @@ Amtk notes
TODO list
---------
+- Support detailed GAction names in factory functions:
+ - In AmtkActionInfo, document that the "action name" can be a detailed
+ action name, with a reference to g_action_parse_detailed_name().
+ - In AmtkFactory, call gtk_actionable_set_detailed_action_name() and
+ adapt docs.
+ - Adapt docs and code in other classes if needed (but I think it's only
+ in AmtkActionInfo and AmtkFactory).
+
- Implement more factory functions.
-- Support detailed GAction names in factory functions.
Other possible things to do
---------------------------
@@ -23,7 +30,9 @@ Other possible things to do
accordingly.
- Add one more sanity check: check that a GAction is *implemented* when (or
- after) creating a menu or toolbar item for that action?
+ after) creating a menu or toolbar item for that action? Because currently
+ when the GAction is not implemented, the menu/toolbar item is just
+ insensitive, there is no warning.
- An AmtkActionInfo could have a field for the default AmtkFactoryFlags (or to
force some flags). For example setting AMTK_FACTORY_IGNORE_ACCELS_FOR_APP for
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]