[gnome-control-center] user-accounts: Remove implicit language setting
- From: Ondrej Holy <oholy src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center] user-accounts: Remove implicit language setting
- Date: Wed, 15 Aug 2018 10:06:10 +0000 (UTC)
commit a1066a27e00c0c2fd0f574df81d76fe8b50f5c4e
Author: Yifan J <yfjiang suse com>
Date: Wed Aug 15 10:06:50 2018 +0800
user-accounts: Remove implicit language setting
The commit targets to remove the behavior of implicit set of the language
when the user panel is clicked in g-c-c.
The behavior looks like introduced to partly resolve the bug [0] when the
gnome-initial-setup somehow did not set the language correctly. However the
gnome-initial-setup is able to handle the language nicely now.
Furthermore, the current user could not see its own language chooser in the
g-c-c User panel, instead the Region&Language panel is supposed to do the
task. And the Region&Language panel has already got a default locale set [1]
[2]. So even if the language is not set in the key file, it is less an issue
nowadays than when the issue was originally described in [0].
[0] https://bugzilla.gnome.org/show_bug.cgi?id=737216
[1] https://bugzilla.gnome.org/show_bug.cgi?id=767065
[2] https://gitlab.gnome.org/GNOME/gnome-control-center/commit/5e2ed8e
https://gitlab.gnome.org/GNOME/gnome-control-center/merge_requests/161
panels/user-accounts/um-user-panel.c | 4 ----
1 file changed, 4 deletions(-)
---
diff --git a/panels/user-accounts/um-user-panel.c b/panels/user-accounts/um-user-panel.c
index 25405b4af..6ccc9e199 100644
--- a/panels/user-accounts/um-user-panel.c
+++ b/panels/user-accounts/um-user-panel.c
@@ -837,10 +837,6 @@ show_user (ActUser *user, CcUserPanel *self)
name = NULL;
lang = g_strdup (act_user_get_language (user));
- if ((!lang || *lang == '\0') && act_user_get_uid (user) == getuid ()) {
- lang = cc_common_language_get_current_language ();
- act_user_set_language (user, lang);
- }
if (lang && *lang != '\0') {
name = gnome_get_language_from_locale (lang, NULL);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]