[polari/wip/fmuellner/warning-fixes: 5/6] mainWindow: Don't destroy notification queues with window
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [polari/wip/fmuellner/warning-fixes: 5/6] mainWindow: Don't destroy notification queues with window
- Date: Mon, 3 Dec 2018 20:07:58 +0000 (UTC)
commit 53939f8ff9e45fd0268cb747d1572264de5b1bad
Author: Florian Müllner <fmuellner gnome org>
Date: Mon Dec 3 16:32:15 2018 +0100
mainWindow: Don't destroy notification queues with window
Both queues are owned by the application, which may outlive the main
window. It probably makes sense to rethink the ownership in the future,
but for now avoid warnings from follow-up main windows by not destroying
them with the previous window.
https://gitlab.gnome.org/GNOME/polari/merge_requests/79
src/mainWindow.js | 3 +++
1 file changed, 3 insertions(+)
---
diff --git a/src/mainWindow.js b/src/mainWindow.js
index 063cac4..dd65c51 100644
--- a/src/mainWindow.js
+++ b/src/mainWindow.js
@@ -250,6 +250,9 @@ var MainWindow = GObject.registerClass({
this._roomManager.disconnect(this._roomsLoadedId);
this._roomManager.disconnect(this._roomRemovedId);
+
+ this._overlay.remove(this.application.notificationQueue);
+ this._overlay.remove(this.application.commandOutputQueue);
}
_touchFile(file) {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]