[vala/0.36] codegen: Actually create method cast for base interface	method as needed
- From: Rico Tzschichholz <ricotz src gnome org>
- To: commits-list gnome org
- Cc: 
- Subject: [vala/0.36] codegen: Actually create method cast for base interface	method as needed
- Date: Thu,  6 Dec 2018 15:04:11 +0000 (UTC)
commit bcc3b4c3828f1edf78dc262648987dae4e748a7d
Author: Rico Tzschichholz <ricotz ubuntu com>
Date:   Sun Nov 25 18:27:32 2018 +0100
    codegen: Actually create method cast for base interface method as needed
    
    Keep the fallback to base method for now.
    
    This will silence some incompatible pointer type warnings.
 codegen/valagtypemodule.vala | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)
---
diff --git a/codegen/valagtypemodule.vala b/codegen/valagtypemodule.vala
index e8c255810..f7a143eae 100644
--- a/codegen/valagtypemodule.vala
+++ b/codegen/valagtypemodule.vala
@@ -1382,10 +1382,11 @@ public class Vala.GTypeModule : GErrorModule {
                                        // method inherited from base class
 
                                        var base_method = cl_method;
-                                       if (cl_method.base_method != null) {
-                                               base_method = cl_method.base_method;
-                                       } else if (cl_method.base_interface_method != null) {
+                                       if (cl_method.base_interface_method != null) {
                                                base_method = cl_method.base_interface_method;
+                                       } else if (cl_method.base_method != null) {
+                                               //FIXME should this ever be possible here?
+                                               base_method = cl_method.base_method;
                                        }
 
                                        generate_method_declaration (base_method, cfile);
[
Date Prev][
Date Next]   [
Thread Prev][
Thread Next]   
[
Thread Index]
[
Date Index]
[
Author Index]