[gnome-shell/wip/carlosg/fix-issue-33] viewSelector: Avoid stealing focus from other entries into overview entry
- From: Carlos Garnacho <carlosg src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell/wip/carlosg/fix-issue-33] viewSelector: Avoid stealing focus from other entries into overview entry
- Date: Fri, 9 Feb 2018 23:35:29 +0000 (UTC)
commit f593c1706d6f1e701428dad40172dfcc547627e0
Author: Carlos Garnacho <carlosg gnome org>
Date: Sat Feb 10 00:18:26 2018 +0100
viewSelector: Avoid stealing focus from other entries into overview entry
The captured-event handler just redirects focus there on the first keypress,
what it doesn't account for is that other entries may be active while the
Activities overview is opened (eg. alt-f2, or other modal dialogs). Play
along with other entries, and make it only steal focus if no other entry
is selected.
https://gitlab.gnome.org/GNOME/gnome-shell/issues/33
Closes: #33
js/ui/viewSelector.js | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
---
diff --git a/js/ui/viewSelector.js b/js/ui/viewSelector.js
index d9a13a3aa..97a949f0e 100644
--- a/js/ui/viewSelector.js
+++ b/js/ui/viewSelector.js
@@ -606,7 +606,8 @@ var ViewSelector = new Lang.Class({
// - cancel the search
this.reset();
}
- } else if (!this._text.has_key_focus() &&
+ } else if (!(global.stage.get_key_focus() instanceof Clutter.Text) &&
+ !this._text.has_key_focus() &&
(event.type() == Clutter.EventType.KEY_PRESS ||
event.type() == Clutter.EventType.KEY_RELEASE)) {
let unichar = event.get_key_unicode();
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]