[gimp] app: don't disable undo for unattached items in gimp_item_{start, end}_move()
- From: N/A <ell src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] app: don't disable undo for unattached items in gimp_item_{start, end}_move()
- Date: Mon, 12 Feb 2018 10:18:51 +0000 (UTC)
commit ac3392477b32530fd05006ad0a3876ad29c47caa
Author: Ell <ell_se yahoo com>
Date: Mon Feb 12 05:10:57 2018 -0500
app: don't disable undo for unattached items in gimp_item_{start,end}_move()
Setting push_undo to FALSE in these functions is premature -- let
this stuff be handled at the actual point where the undo is
pushed, which might correspond to a different item than the one for
which gimp_item_{start,end}_move() was called.
In particular, when removing a layer from the image,
gimp_item_end_move() is called (with push_undo == TRUE) on the
layer after it's been removed, but we still need the appropriate
undo enrties to be pushed for the affected group layers.
app/core/gimpitem.c | 6 ------
1 files changed, 0 insertions(+), 6 deletions(-)
---
diff --git a/app/core/gimpitem.c b/app/core/gimpitem.c
index 536a42a..1fbf375 100644
--- a/app/core/gimpitem.c
+++ b/app/core/gimpitem.c
@@ -1190,9 +1190,6 @@ gimp_item_start_move (GimpItem *item,
{
g_return_if_fail (GIMP_IS_ITEM (item));
- if (! gimp_item_is_attached (item))
- push_undo = FALSE;
-
if (GIMP_ITEM_GET_CLASS (item)->start_move)
GIMP_ITEM_GET_CLASS (item)->start_move (item, push_undo);
}
@@ -1203,9 +1200,6 @@ gimp_item_end_move (GimpItem *item,
{
g_return_if_fail (GIMP_IS_ITEM (item));
- if (! gimp_item_is_attached (item))
- push_undo = FALSE;
-
if (GIMP_ITEM_GET_CLASS (item)->end_move)
GIMP_ITEM_GET_CLASS (item)->end_move (item, push_undo);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]