[gnome-photos] view-container: Use a switch for enums instead of if-else
- From: Debarshi Ray <debarshir src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-photos] view-container: Use a switch for enums instead of if-else
- Date: Wed, 14 Feb 2018 22:23:42 +0000 (UTC)
commit f257089ebd414d998e420eda2bee4f461e9638d1
Author: Debarshi Ray <debarshir gnome org>
Date: Wed Feb 14 22:52:41 2018 +0100
view-container: Use a switch for enums instead of if-else
Using a switch statement lets the compiler warn us through
-Wswitch-enum whenever the enumeration is extended. An if-else block
does not do that.
src/photos-view-container.c | 24 +++++++++++++++++++-----
1 file changed, 19 insertions(+), 5 deletions(-)
---
diff --git a/src/photos-view-container.c b/src/photos-view-container.c
index 1679bf1e..949cbec1 100644
--- a/src/photos-view-container.c
+++ b/src/photos-view-container.c
@@ -278,11 +278,25 @@ photos_view_container_window_mode_changed (PhotosViewContainer *self,
{
photos_view_container_disconnect_view (self);
- if (mode == PHOTOS_WINDOW_MODE_COLLECTIONS
- || mode == PHOTOS_WINDOW_MODE_FAVORITES
- || mode == PHOTOS_WINDOW_MODE_OVERVIEW
- || mode == PHOTOS_WINDOW_MODE_SEARCH)
- photos_view_container_connect_view (self);
+ switch (mode)
+ {
+ case PHOTOS_WINDOW_MODE_NONE:
+ g_assert_not_reached ();
+ break;
+
+ case PHOTOS_WINDOW_MODE_COLLECTIONS:
+ case PHOTOS_WINDOW_MODE_FAVORITES:
+ case PHOTOS_WINDOW_MODE_OVERVIEW:
+ case PHOTOS_WINDOW_MODE_SEARCH:
+ photos_view_container_connect_view (self);
+ break;
+
+ case PHOTOS_WINDOW_MODE_COLLECTION_VIEW:
+ case PHOTOS_WINDOW_MODE_EDIT:
+ case PHOTOS_WINDOW_MODE_PREVIEW:
+ default:
+ break;
+ }
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]