[gnome-software/jrocha/fix-install-queue: 4/8] Allow to cancel installation of apps that were queued for install



commit 55c451143aa04b04745590dbd78631c45acbe782
Author: Joaquim Rocha <jrocha endlessm com>
Date:   Thu Feb 15 23:28:41 2018 +0100

    Allow to cancel installation of apps that were queued for install
    
    When apps were queued for installation, and the network became
    available, they were being installed without having any cancellable
    being used. This meant that cancelling the installation was not
    possible even if the used clicked the cancel button.
    
    This patch makes the installation process in question to use the
    cancellable from the app being installed, which is what the cancel
    button in the details view uses for cancelling the on-going
    operations.
    
    https://phabricator.endlessm.com/T21194

 lib/gs-plugin-loader.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/lib/gs-plugin-loader.c b/lib/gs-plugin-loader.c
index 78d32ff2..592b7d2b 100644
--- a/lib/gs-plugin-loader.c
+++ b/lib/gs-plugin-loader.c
@@ -2985,7 +2985,7 @@ gs_plugin_loader_network_changed_cb (GNetworkMonitor *monitor,
                                                         "failure-flags", GS_PLUGIN_FAILURE_FLAGS_USE_EVENTS,
                                                         NULL);
                        gs_plugin_loader_job_process_async (plugin_loader, plugin_job,
-                                                           NULL,
+                                                           gs_app_get_cancellable (app),
                                                            gs_plugin_loader_app_installed_cb,
                                                            g_object_ref (app));
                }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]