[gnome-panel/wip/geiger/geometry: 6/6] some random code

[Sebastian Geiger <segeiger src gnome org>]

commit 5a754fa04ef30dd5dd44b7c63bb062c9bf2a7eaf
Author: Sebastian Geiger <sbastig gmx net>
Date:   Fri Feb 16 20:35:09 2018 +0100

    some random code

 .../libpanel-applet-private/gp-applet-manager.c    |    1 +
 gnome-panel/panel-struts.c                         |    2 ++
 gnome-panel/panel-toplevel.c                       |    2 ++
 libgnome-panel/gp-module.c                         |    2 ++
 libpanel-applet/panel-applet.c                     |   16 +++++++++++++---
 5 files changed, 20 insertions(+), 3 deletions(-)
---
diff --git a/gnome-panel/libpanel-applet-private/gp-applet-manager.c 
b/gnome-panel/libpanel-applet-private/gp-applet-manager.c
index 5d44700..f6eef89 100644
--- a/gnome-panel/libpanel-applet-private/gp-applet-manager.c
+++ b/gnome-panel/libpanel-applet-private/gp-applet-manager.c
@@ -99,6 +99,7 @@ load_external_modules (GpAppletManager *manager)
 
       g_hash_table_insert (manager->modules, g_strdup (id), module);
       get_applet_infos (manager, id, module);
+      g_debug("Loading module id: %s", id);
     }
 
   g_dir_close (dir);
diff --git a/gnome-panel/panel-struts.c b/gnome-panel/panel-struts.c
index f378561..b6c9ad1 100644
--- a/gnome-panel/panel-struts.c
+++ b/gnome-panel/panel-struts.c
@@ -196,6 +196,8 @@ panel_struts_allocate_struts (PanelToplevel *toplevel,
                        skip = panel_struts_allocation_overlapped (
                                strut, overlap, &geometry, &moved_down, skip);
 
+               // TODO: shouldn't there be some assignment for x values and width here?
+
                if (strut->orientation & PANEL_VERTICAL_MASK) {
                        if (geometry.y < monitor_geometry.y) {
                                geometry.height = geometry.y + geometry.height - monitor_geometry.y;
diff --git a/gnome-panel/panel-toplevel.c b/gnome-panel/panel-toplevel.c
index 13bf418..31b8c24 100644
--- a/gnome-panel/panel-toplevel.c
+++ b/gnome-panel/panel-toplevel.c
@@ -4176,6 +4176,8 @@ panel_toplevel_init (PanelToplevel *toplevel)
                          G_CALLBACK (gtk_true),
                          NULL);
 
+       //todo: listen to monitor-changed signal and redraw our self
+
        update_style_classes (toplevel);
 }
 
diff --git a/libgnome-panel/gp-module.c b/libgnome-panel/gp-module.c
index 91e879a..a4883c3 100644
--- a/libgnome-panel/gp-module.c
+++ b/libgnome-panel/gp-module.c
@@ -341,6 +341,8 @@ gp_module_new_from_path (const gchar *path)
   module->path = g_strdup (path);
   module->library = g_module_open (path, flags);
 
+  g_debug("Loading module (path): %s", path);
+
   if (module->library == NULL)
     {
       g_warning ("Failed to load module '%s': %s", path, g_module_error ());
diff --git a/libpanel-applet/panel-applet.c b/libpanel-applet/panel-applet.c
index 7d33b1b..4301ce2 100644
--- a/libpanel-applet/panel-applet.c
+++ b/libpanel-applet/panel-applet.c
@@ -160,15 +160,25 @@ G_DEFINE_TYPE_WITH_PRIVATE (PanelApplet, panel_applet, GTK_TYPE_EVENT_BOX)
  **/
 GSettings *
 panel_applet_settings_new (PanelApplet *applet,
-                          const char  *schema)
+                          const char  *schema_id)
 {
        g_return_val_if_fail (PANEL_IS_APPLET (applet), NULL);
-       g_return_val_if_fail (schema != NULL, NULL);
+       g_return_val_if_fail (schema_id != NULL, NULL);
 
        if (!applet->priv->settings_path)
                return NULL;
 
-       return g_settings_new_with_path (schema, applet->priv->settings_path);
+        printf("new\n");
+
+       GSettingsSchemaSource *schema_source = g_settings_schema_source_get_default ();
+
+       GSettingsSchema *schema = g_settings_schema_source_lookup (schema_source,
+                                                                  schema_id, FALSE);
+
+       if (!schema)
+               return NULL;
+
+       return g_settings_new_with_path (schema_id, applet->priv->settings_path);
 }
 
 static void