[gnome-music/wip/mschraal/grilo-error-report: 1/2] grilo: Report errors
- From: Marinus Schraal <mschraal src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-music/wip/mschraal/grilo-error-report: 1/2] grilo: Report errors
- Date: Tue, 20 Feb 2018 18:24:28 +0000 (UTC)
commit 3aa7a8b918b160bc667a30a9c31dc3ffd42f2073
Author: Marinus Schraal <mschraal gnome org>
Date: Tue Feb 20 15:06:54 2018 +0100
grilo: Report errors
gnomemusic/grilo.py | 30 +++++++++++++++++++++++-------
1 file changed, 23 insertions(+), 7 deletions(-)
---
diff --git a/gnomemusic/grilo.py b/gnomemusic/grilo.py
index 46dcad4..133466a 100644
--- a/gnomemusic/grilo.py
+++ b/gnomemusic/grilo.py
@@ -293,6 +293,9 @@ class Grilo(GObject.GObject):
options.set_count(count)
def _callback(source, param, item, remaining, data, error):
+ if error:
+ logger.warning("Error {}: {}".format(
+ error.domain, error.message))
callback(source, param, item, remaining, data)
self.tracker.query(query, self.METADATA_KEYS, options, _callback, data)
@@ -313,9 +316,11 @@ class Grilo(GObject.GObject):
# FIXME: We assume this is the tracker plugin.
# FIXME: Doing this async crashes
- self.tracker.store_metadata_sync(song_item,
- [Grl.METADATA_KEY_FAVOURITE],
- Grl.WriteFlags.NORMAL)
+ try:
+ self.tracker.store_metadata_sync(
+ song_item, [Grl.METADATA_KEY_FAVOURITE], Grl.WriteFlags.NORMAL)
+ except GLib.Error as error:
+ logger.warning("Error {}: {}".format(error.domain, error.message))
@log
def set_favorite(self, song_item, favorite):
@@ -334,11 +339,16 @@ class Grilo(GObject.GObject):
@log
def _search_callback(source, param, item, remaining, data, error):
+ if error:
+ logger.warning("Error {}: {}".format(
+ error.domain, error.message))
callback(source, param, item, remaining, data)
self._search_callback_counter += 1
@log
def _multiple_search_callback(source, param, item, remaining, data, error):
+ if error:
+ logger.warning("Error {}: {}".format(error.domain, error.message))
callback(source, param, item, remaining, data)
if self.search_source:
@@ -393,8 +403,11 @@ class Grilo(GObject.GObject):
# FIXME: We assume this is the tracker plugin.
# FIXME: Doing this async crashes
- self.tracker.store_metadata_sync(media, [Grl.METADATA_KEY_PLAY_COUNT],
- Grl.WriteFlags.NORMAL)
+ try:
+ self.tracker.store_metadata_sync(
+ media, [Grl.METADATA_KEY_PLAY_COUNT], Grl.WriteFlags.NORMAL)
+ except GLib.Error as error:
+ logger.warning("Error {}: {}".format(error.domain, error.message))
@log
def set_last_played(self, media):
@@ -406,8 +419,11 @@ class Grilo(GObject.GObject):
media.set_last_played(GLib.DateTime.new_now_utc())
# FIXME: We assume this is the tracker plugin.
# FIXME: Doing this async crashes
- self.tracker.store_metadata_sync(media, [Grl.METADATA_KEY_LAST_PLAYED],
- Grl.WriteFlags.NORMAL)
+ try:
+ self.tracker.store_metadata_sync(
+ media, [Grl.METADATA_KEY_LAST_PLAYED], Grl.WriteFlags.NORMAL)
+ except GLib.Error as error:
+ logger.warning("Error {}: {}".format(error.domain, error.message))
@log
def songs_available(self, callback):
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]