[devhelp] Sidebar: remove get_selected_book() from public API
- From: Sébastien Wilmet <swilmet src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [devhelp] Sidebar: remove get_selected_book() from public API
- Date: Thu, 4 Jan 2018 19:04:59 +0000 (UTC)
commit 2c1d70386a6c509c8254a147a3df0205603ad5f6
Author: Sébastien Wilmet <swilmet gnome org>
Date: Thu Jan 4 19:59:17 2018 +0100
Sidebar: remove get_selected_book() from public API
docs/reference/api-breaks.xml | 8 +++++++-
docs/reference/devhelp-sections.txt | 1 -
src/dh-sidebar.c | 22 +---------------------
src/dh-sidebar.h | 2 --
4 files changed, 8 insertions(+), 25 deletions(-)
---
diff --git a/docs/reference/api-breaks.xml b/docs/reference/api-breaks.xml
index b617df4..1288056 100644
--- a/docs/reference/api-breaks.xml
+++ b/docs/reference/api-breaks.xml
@@ -190,7 +190,7 @@
<para>
The ownership transfer of the return values of
<link linkend="dh-book-tree-get-selected-book">dh_book_tree_get_selected_book()</link>
- and <link linkend="dh-sidebar-get-selected-book">dh_sidebar_get_selected_book()</link>
+ and <code>dh_sidebar_get_selected_book()</code>
have been changed from (transfer none) to (transfer full).
</para>
</listitem>
@@ -219,6 +219,12 @@
<link linkend="GtkBox">GtkBox</link>.
</para>
</listitem>
+ <listitem>
+ <para>
+ <code>dh_sidebar_get_selected_book()</code> has been removed (it was
+ used only inside DhSidebar).
+ </para>
+ </listitem>
</itemizedlist>
</refsect1>
</part>
diff --git a/docs/reference/devhelp-sections.txt b/docs/reference/devhelp-sections.txt
index fe9d168..b7cc7fd 100644
--- a/docs/reference/devhelp-sections.txt
+++ b/docs/reference/devhelp-sections.txt
@@ -135,7 +135,6 @@ dh_link_type_get_type
<FILE>dh-sidebar</FILE>
DhSidebar
dh_sidebar_new
-dh_sidebar_get_selected_book
dh_sidebar_select_uri
dh_sidebar_set_search_string
dh_sidebar_set_search_focus
diff --git a/src/dh-sidebar.c b/src/dh-sidebar.c
index d0c5903..d2be36b 100644
--- a/src/dh-sidebar.c
+++ b/src/dh-sidebar.c
@@ -145,7 +145,7 @@ filter_idle_cb (gpointer user_data)
search_text = gtk_entry_get_text (priv->entry);
- book_link = dh_sidebar_get_selected_book (sidebar);
+ book_link = dh_book_tree_get_selected_book (priv->book_tree);
book_id = book_link != NULL ? dh_link_get_book_id (book_link) : NULL;
/* Disconnect the model during the filter, for:
@@ -612,26 +612,6 @@ dh_sidebar_new (DhBookManager *book_manager)
}
/**
- * dh_sidebar_get_selected_book:
- * @sidebar: a #DhSidebar.
- *
- * Returns: (nullable) (transfer full): the #DhLink of the selected book, or
- * %NULL if there is no selection. Unref with dh_link_unref() when no longer
- * needed.
- */
-DhLink *
-dh_sidebar_get_selected_book (DhSidebar *sidebar)
-{
- DhSidebarPrivate *priv;
-
- g_return_val_if_fail (DH_IS_SIDEBAR (sidebar), NULL);
-
- priv = dh_sidebar_get_instance_private (sidebar);
-
- return dh_book_tree_get_selected_book (priv->book_tree);
-}
-
-/**
* dh_sidebar_select_uri:
* @sidebar: a #DhSidebar.
* @uri: the URI to select.
diff --git a/src/dh-sidebar.h b/src/dh-sidebar.h
index 8621e92..07282d4 100644
--- a/src/dh-sidebar.h
+++ b/src/dh-sidebar.h
@@ -56,8 +56,6 @@ GType dh_sidebar_get_type (void);
GtkWidget * dh_sidebar_new (DhBookManager *book_manager);
-DhLink * dh_sidebar_get_selected_book (DhSidebar *sidebar);
-
void dh_sidebar_select_uri (DhSidebar *sidebar,
const gchar *uri);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]