[epiphany] Don't notify after downloading adblock filters
- From: Michael Catanzaro <mcatanzaro src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [epiphany] Don't notify after downloading adblock filters
- Date: Sun, 7 Jan 2018 00:37:51 +0000 (UTC)
commit f2673183b09293ed53ee418c957e1a4397110035
Author: Michael Catanzaro <mcatanzaro igalia com>
Date: Sat Jan 6 18:35:33 2018 -0600
Don't notify after downloading adblock filters
"Finished downloading 17ba74de8f13543dbff29e37b3ce125d! Yippee!"
-- Every user ever
https://bugzilla.gnome.org/show_bug.cgi?id=722142
embed/ephy-download.c | 16 +++++++++++++++-
embed/ephy-download.h | 2 ++
embed/ephy-filters-manager.c | 1 +
3 files changed, 18 insertions(+), 1 deletions(-)
---
diff --git a/embed/ephy-download.c b/embed/ephy-download.c
index 13e4364..b98586d 100644
--- a/embed/ephy-download.c
+++ b/embed/ephy-download.c
@@ -41,6 +41,8 @@ struct _EphyDownload {
char *destination;
char *content_type;
+ gboolean show_notification;
+
EphyDownloadActionType action;
guint32 start_time;
gboolean finished;
@@ -602,6 +604,8 @@ ephy_download_init (EphyDownload *download)
download->action = EPHY_DOWNLOAD_ACTION_NONE;
download->start_time = gtk_get_current_event_time ();
+
+ download->show_notification = TRUE;
}
static void
@@ -724,7 +728,9 @@ download_finished_cb (WebKitDownload *wk_download,
else
ephy_download_do_download_action (download, download->action, download->start_time);
- display_download_finished_notification (wk_download);
+ if (download->show_notification)
+ display_download_finished_notification (wk_download);
+
g_signal_emit (download, signals[COMPLETED], 0);
}
@@ -803,3 +809,11 @@ ephy_download_new_for_uri (const char *uri)
return ephy_download;
}
+
+void
+ephy_download_disable_desktop_notification (EphyDownload *download)
+{
+ g_assert (EPHY_IS_DOWNLOAD (download));
+
+ download->show_notification = FALSE;
+}
diff --git a/embed/ephy-download.h b/embed/ephy-download.h
index e71ff01..d243581 100644
--- a/embed/ephy-download.h
+++ b/embed/ephy-download.h
@@ -61,5 +61,7 @@ void ephy_download_set_action (EphyDownload *download,
gboolean ephy_download_do_download_action (EphyDownload *download,
EphyDownloadActionType action,
guint32 user_time);
+void ephy_download_disable_desktop_notification
+ (EphyDownload *download);
G_END_DECLS
diff --git a/embed/ephy-filters-manager.c b/embed/ephy-filters-manager.c
index 20ca374..7e4cebc 100644
--- a/embed/ephy-filters-manager.c
+++ b/embed/ephy-filters-manager.c
@@ -150,6 +150,7 @@ start_retrieving_filter_file (EphyFiltersManager *manager,
download = ephy_download_new_for_uri (filter_url);
path = g_file_get_uri (destination);
ephy_download_set_destination_uri (download, path);
+ ephy_download_disable_desktop_notification (download);
g_free (path);
wk_download = ephy_download_get_webkit_download (download);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]