[gnome-shell-extensions/gnome-3-26] window-list: Fix icons not showing for some windows on wayland
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell-extensions/gnome-3-26] window-list: Fix icons not showing for some windows on wayland
- Date: Sat, 20 Jan 2018 13:53:00 +0000 (UTC)
commit 683b5eee754d63da43c5d7a94fa5e126f7430050
Author: Florian Müllner <fmuellner gnome org>
Date: Mon Dec 25 10:21:18 2017 +0100
window-list: Fix icons not showing for some windows on wayland
On wayland, the properties that are used for application matching
are generally set after the window has been created, so it is
normal that buttons start with the fallback icon. While we already
track the properties that are relevant for app matching, our signal
handler may run before the window is matched to its app.
Make sure the WindowTracker gets to process those signals first by
using connect_after() for our own handlers.
Fixes https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/10.
extensions/window-list/extension.js | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
---
diff --git a/extensions/window-list/extension.js b/extensions/window-list/extension.js
index f01b872..6c439af 100644
--- a/extensions/window-list/extension.js
+++ b/extensions/window-list/extension.js
@@ -162,11 +162,11 @@ const WindowTitle = new Lang.Class({
this._textureCache.connect('icon-theme-changed',
Lang.bind(this, this._updateIcon));
this._notifyWmClass =
- this._metaWindow.connect('notify::wm-class',
- Lang.bind(this, this._updateIcon));
+ this._metaWindow.connect_after('notify::wm-class',
+ Lang.bind(this, this._updateIcon));
this._notifyAppId =
- this._metaWindow.connect('notify::gtk-application-id',
- Lang.bind(this, this._updateIcon));
+ this._metaWindow.connect_after('notify::gtk-application-id',
+ Lang.bind(this, this._updateIcon));
this._updateIcon();
this.actor.connect('destroy', Lang.bind(this, this._onDestroy));
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]