[gjs: 3/6] maint: Fix obsolete comments on resolve hooks
- From: Cosimo Cecchi <cosimoc src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gjs: 3/6] maint: Fix obsolete comments on resolve hooks
- Date: Sat, 27 Jan 2018 22:21:03 +0000 (UTC)
commit dd42bdcc7df5ef8fb963de90bdbf23add9a08f97
Author: Philip Chimento <philip chimento gmail com>
Date: Sun Jan 21 15:00:28 2018 -0800
maint: Fix obsolete comments on resolve hooks
Previously, these comments referred to the way the resolve operation used
to work, with a JSObject **objp out parameter.
gi/boxed.cpp | 7 ++-----
gi/ns.cpp | 7 ++-----
gi/object.cpp | 7 ++-----
gjs/importer.cpp | 7 ++-----
4 files changed, 8 insertions(+), 20 deletions(-)
---
diff --git a/gi/boxed.cpp b/gi/boxed.cpp
index fa8d6c3..a52972c 100644
--- a/gi/boxed.cpp
+++ b/gi/boxed.cpp
@@ -110,11 +110,8 @@ gjs_define_static_methods(JSContext *context,
return true;
}
-/*
- * The *objp out parameter, on success, should be null to indicate that id
- * was not resolved; and non-null, referring to obj or one of its prototypes,
- * if id was resolved.
- */
+/* The *resolved out parameter, on success, should be false to indicate that id
+ * was not resolved; and true if id was resolved. */
static bool
boxed_resolve(JSContext *context,
JS::HandleObject obj,
diff --git a/gi/ns.cpp b/gi/ns.cpp
index 0ca5620..edf2b42 100644
--- a/gi/ns.cpp
+++ b/gi/ns.cpp
@@ -43,11 +43,8 @@ extern struct JSClass gjs_ns_class;
GJS_DEFINE_PRIV_FROM_JS(Ns, gjs_ns_class)
-/*
- * The *objp out parameter, on success, should be null to indicate that id
- * was not resolved; and non-null, referring to obj or one of its prototypes,
- * if id was resolved.
- */
+/* The *resolved out parameter, on success, should be false to indicate that id
+ * was not resolved; and true if id was resolved. */
static bool
ns_resolve(JSContext *context,
JS::HandleObject obj,
diff --git a/gi/object.cpp b/gi/object.cpp
index a0fc16a..0b24cc4 100644
--- a/gi/object.cpp
+++ b/gi/object.cpp
@@ -708,11 +708,8 @@ is_gobject_field_name(GIObjectInfo *info,
return true;
}
-/*
- * The *objp out parameter, on success, should be null to indicate that id
- * was not resolved; and non-null, referring to obj or one of its prototypes,
- * if id was resolved.
- */
+/* The *resolved out parameter, on success, should be false to indicate that id
+ * was not resolved; and true if id was resolved. */
static bool
object_instance_resolve(JSContext *context,
JS::HandleObject obj,
diff --git a/gjs/importer.cpp b/gjs/importer.cpp
index 097abd9..7060007 100644
--- a/gjs/importer.cpp
+++ b/gjs/importer.cpp
@@ -746,11 +746,8 @@ importer_enumerate(JSContext *context,
return true;
}
-/*
- * The *objp out parameter, on success, should be null to indicate that id
- * was not resolved; and non-null, referring to obj or one of its prototypes,
- * if id was resolved.
- */
+/* The *resolved out parameter, on success, should be false to indicate that id
+ * was not resolved; and true if id was resolved. */
static bool
importer_resolve(JSContext *context,
JS::HandleObject obj,
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]