[gnome-builder] valgrind: disconnect notify handler on unload
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder] valgrind: disconnect notify handler on unload
- Date: Wed, 31 Jan 2018 10:29:57 +0000 (UTC)
commit 629931dcd7df737736109702669d9447da1deaa1
Author: Christian Hergert <chergert redhat com>
Date: Wed Jan 31 02:18:10 2018 -0800
valgrind: disconnect notify handler on unload
src/plugins/valgrind/valgrind_plugin.py | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
---
diff --git a/src/plugins/valgrind/valgrind_plugin.py b/src/plugins/valgrind/valgrind_plugin.py
index 699fcf3b9..ec61812bc 100644
--- a/src/plugins/valgrind/valgrind_plugin.py
+++ b/src/plugins/valgrind/valgrind_plugin.py
@@ -31,12 +31,13 @@ _ = Ide.gettext
class ValgrindWorkbenchAddin(GObject.Object, Ide.WorkbenchAddin):
workbench = None
has_handler = False
+ notify_handler = None
def do_load(self, workbench):
self.workbench = workbench
- build_manager = self.workbench.get_context().get_build_manager()
- build_manager.connect('notify::pipeline', self.notify_pipeline)
+ build_manager = workbench.get_context().get_build_manager()
+ self.notify_handler = build_manager.connect('notify::pipeline', self.notify_pipeline)
self.notify_pipeline(build_manager, None)
def notify_pipeline(self, build_manager, pspec):
@@ -57,9 +58,14 @@ class ValgrindWorkbenchAddin(GObject.Object, Ide.WorkbenchAddin):
run_manager.remove_handler('valgrind')
def do_unload(self, workbench):
+ build_manager = workbench.get_context().get_build_manager()
+ build_manager.disconnect(self.notify_handler)
+ self.notify_handler = None
+
if self.has_handler:
- run_manager = self.workbench.get_context().get_run_manager()
+ run_manager = workbench.get_context().get_run_manager()
run_manager.remove_handler('valgrind')
+
self.workbench = None
def valgrind_handler(self, run_manager, runner):
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]