[lightsoff/wip/gtkview] Use foreach instead of double loop
- From: Robert Roth <robertroth src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [lightsoff/wip/gtkview] Use foreach instead of double loop
- Date: Sat, 14 Jul 2018 22:21:50 +0000 (UTC)
commit 2ff3cb50e98cf373992cc265557e6a007c31c81b
Author: Robert Roth <robert roth off gmail com>
Date: Sun Jul 15 01:21:06 2018 +0300
Use foreach instead of double loop
src/board-view-gtk.vala | 12 +++---------
1 file changed, 3 insertions(+), 9 deletions(-)
---
diff --git a/src/board-view-gtk.vala b/src/board-view-gtk.vala
index 359015d..56d6f55 100644
--- a/src/board-view-gtk.vala
+++ b/src/board-view-gtk.vala
@@ -76,9 +76,7 @@ public class BoardViewGtk : Gtk.Grid, BoardView
// Toggle a light and those in each cardinal direction around it.
private void toggle_light (int x, int y, bool clicked = true)
{
- for (var xi = 0; xi < size; xi++)
- for (var yi = 0; yi < size; yi++)
- lights[xi, yi].toggled.disconnect (light_toggled_cb);
+ @foreach((light) => (light as Gtk.ToggleButton).toggled.disconnect (light_toggled_cb));
if (x>= size || y >= size || x < 0 || y < 0 )
return;
@@ -94,9 +92,7 @@ public class BoardViewGtk : Gtk.Grid, BoardView
if (!clicked)
lights[(int) x, (int) y].set_active (!lights[(int) x, (int) y ].get_active ());
- for (var xi = 0; xi < size; xi++)
- for (var yi = 0; yi < size; yi++)
- lights[xi, yi].toggled.connect (light_toggled_cb);
+ @foreach((light) => (light as Gtk.ToggleButton).toggled.connect (light_toggled_cb));
}
// Pseudorandomly generates and sets the state of each light based on
@@ -109,9 +105,7 @@ public class BoardViewGtk : Gtk.Grid, BoardView
if (level < 1)
level = 1;
- for (var xi = 0; xi < size; xi++)
- for (var yi = 0; yi < size; yi++)
- lights[xi, yi].toggled.disconnect (light_toggled_cb);
+ @foreach((light) => (light as Gtk.ToggleButton).toggled.disconnect (light_toggled_cb));
/* Clear level */
for (var x = 0; x < size; x++)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]