[gnome-games/wip/aplazas/fix-warning: 6/6] grilo: Drop useless calls to fetching functions



commit 330c40e0c0373fcbaa97498d48f5b070ffae3ea2
Author: Adrien Plazas <kekun plazas laposte net>
Date:   Sun Jul 22 15:44:53 2018 +0200

    grilo: Drop useless calls to fetching functions
    
    In GriloCooperative, GriloGenre, GriloPlayers and GriloReleaseDate, the
    fetching functions were called just after the data got fetched. These
    calls could only result in directly returning the fetched data, data
    which was unused, making these calls pointless.

 src/grilo/grilo-cooperative.vala  | 1 -
 src/grilo/grilo-genre.vala        | 1 -
 src/grilo/grilo-players.vala      | 1 -
 src/grilo/grilo-release-date.vala | 1 -
 4 files changed, 4 deletions(-)
---
diff --git a/src/grilo/grilo-cooperative.vala b/src/grilo/grilo-cooperative.vala
index e848910e..b19c6cd8 100644
--- a/src/grilo/grilo-cooperative.vala
+++ b/src/grilo/grilo-cooperative.vala
@@ -44,7 +44,6 @@ public class Games.GriloCooperative : Object, Cooperative {
        private void load_media_cooperative(bool coop) {
                cooperative = coop;
                resolving = true;
-               get_cooperative ();
 
                changed();
        }
diff --git a/src/grilo/grilo-genre.vala b/src/grilo/grilo-genre.vala
index 3403226d..c8a41750 100644
--- a/src/grilo/grilo-genre.vala
+++ b/src/grilo/grilo-genre.vala
@@ -48,7 +48,6 @@ public class Games.GriloGenre : Object, Genre {
        private void load_media_genre(List<string> genre_list) {
                genre = genre_list.copy();
                resolving = true;
-               get_genre ();
 
                changed();
        }
diff --git a/src/grilo/grilo-players.vala b/src/grilo/grilo-players.vala
index 4a380f26..62bcb2fd 100644
--- a/src/grilo/grilo-players.vala
+++ b/src/grilo/grilo-players.vala
@@ -53,7 +53,6 @@ public class Games.GriloPlayers : Object, Players {
        private void load_media_players (string player) {
                players = player;
                resolving = true;
-               get_players ();
 
                changed();
        }
diff --git a/src/grilo/grilo-release-date.vala b/src/grilo/grilo-release-date.vala
index 3a2880de..d4aeb0aa 100644
--- a/src/grilo/grilo-release-date.vala
+++ b/src/grilo/grilo-release-date.vala
@@ -42,7 +42,6 @@ public class Games.GriloReleaseDate : Object, ReleaseDate {
        private void load_media_release_date (DateTime release) {
                release_date = release;
                resolving = true;
-               get_release_date ();
 
                changed();
        }


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]