[geary/wip/40-backslash-in-folder-name-0.12] IMAP flags should always be atoms, so should never be quoted.
- From: Michael Gratton <mjog src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [geary/wip/40-backslash-in-folder-name-0.12] IMAP flags should always be atoms, so should never be quoted.
- Date: Sat, 28 Jul 2018 04:46:43 +0000 (UTC)
commit 7712db381e4328badcd1a1c282c81ba39bd27866
Author: Michael James Gratton <mike vee net>
Date: Sat Jul 28 14:37:38 2018 +1000
IMAP flags should always be atoms, so should never be quoted.
src/engine/imap/message/imap-flag.vala | 19 ++++++++++++-------
1 file changed, 12 insertions(+), 7 deletions(-)
---
diff --git a/src/engine/imap/message/imap-flag.vala b/src/engine/imap/message/imap-flag.vala
index c26f59fb..96dbfa56 100644
--- a/src/engine/imap/message/imap-flag.vala
+++ b/src/engine/imap/message/imap-flag.vala
@@ -15,11 +15,16 @@
public abstract class Geary.Imap.Flag : BaseObject, Gee.Hashable<Geary.Imap.Flag> {
public string value { get; private set; }
-
- public Flag(string value) {
- this.value = value;
+
+ /**
+ * Constructs a new flag.
+ *
+ * The given keyword must be an IMAP atom.
+ */
+ public Flag(string name) {
+ this.value = name;
}
-
+
public bool is_system() {
return value[0] == '\\';
}
@@ -31,14 +36,14 @@ public abstract class Geary.Imap.Flag : BaseObject, Gee.Hashable<Geary.Imap.Flag
public bool equal_to(Geary.Imap.Flag flag) {
return (flag == this) ? true : flag.equals_string(value);
}
-
+
/**
* Returns the {@link Flag} as an appropriate {@link Parameter}.
*/
public StringParameter to_parameter() throws ImapError {
- return StringParameter.get_best_for(value);
+ return new UnquotedStringParameter(value);
}
-
+
public uint hash() {
return Ascii.stri_hash(value);
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]