[gnome-control-center/wip/benzea/ci-network: 8/17] network: Fix crash on connection change after device removal
- From: Georges Basile Stavracas Neto <gbsneto src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-control-center/wip/benzea/ci-network: 8/17] network: Fix crash on connection change after device removal
- Date: Wed, 2 May 2018 22:30:28 +0000 (UTC)
commit e91266a8f0643de1166bc81431e0c7bb22782614
Author: Benjamin Berg <bberg redhat com>
Date: Wed Mar 28 01:36:52 2018 +0200
network: Fix crash on connection change after device removal
When a device is removed the callback handler could still be called
because it was connected using g_signal_connect rather than
g_signal_connect_object. This fixes crashes in the UI after a device has
been removed again.
panels/network/net-device-ethernet.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/panels/network/net-device-ethernet.c b/panels/network/net-device-ethernet.c
index 0412facaf..afb544352 100644
--- a/panels/network/net-device-ethernet.c
+++ b/panels/network/net-device-ethernet.c
@@ -551,8 +551,8 @@ device_ethernet_constructed (GObject *object)
G_CALLBACK (add_profile), device);
client = net_object_get_client (NET_OBJECT (object));
- g_signal_connect (client, NM_CLIENT_CONNECTION_ADDED,
- G_CALLBACK (client_connection_added_cb), object);
+ g_signal_connect_object (client, NM_CLIENT_CONNECTION_ADDED,
+ G_CALLBACK (client_connection_added_cb), object, 0);
g_signal_connect_object (client, NM_CLIENT_CONNECTION_REMOVED,
G_CALLBACK (connection_removed), device, 0);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]