[glib] Revert "Fix the cmp implementation for variant values"
- From: Philip Withnall <pwithnall src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [glib] Revert "Fix the cmp implementation for variant values"
- Date: Fri, 4 May 2018 16:23:59 +0000 (UTC)
commit a06117d0623ec0ddef895db605bac09460daae15
Author: Philip Withnall <withnall endlessm com>
Date: Fri May 4 17:22:17 2018 +0100
Revert "Fix the cmp implementation for variant values"
This reverts commit 566e64a660549cd49741f244f6362af47eae3757.
This fix went from one broken state to another. The real fix is to use
g_variant_compare(), which is pending review. See bug #795735.
https://bugzilla.gnome.org/show_bug.cgi?id=795735
gobject/gparamspecs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
---
diff --git a/gobject/gparamspecs.c b/gobject/gparamspecs.c
index 9c1259241..8c285fa1c 100644
--- a/gobject/gparamspecs.c
+++ b/gobject/gparamspecs.c
@@ -1155,7 +1155,7 @@ param_variant_values_cmp (GParamSpec *pspec,
GVariant *v1 = value1->data[0].v_pointer;
GVariant *v2 = value2->data[0].v_pointer;
- return v1 < v2 ? -1 : v1 > v2;
+ return v1 < v2 ? -1 : v2 > v1;
}
/* --- type initialization --- */
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]