[gnome-builder/wip/chergert/completion] completion: make load private API
- From: Christian Hergert <chergert src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-builder/wip/chergert/completion] completion: make load private API
- Date: Thu, 10 May 2018 06:24:54 +0000 (UTC)
commit a6211e975f2f6ab405b2d4114f85af5832c8fe49
Author: Christian Hergert <chergert redhat com>
Date: Wed May 9 23:22:20 2018 -0700
completion: make load private API
src/libide/completion/ide-completion-private.h | 2 ++
src/libide/completion/ide-completion-provider.c | 9 +++++----
src/libide/completion/ide-completion-provider.h | 3 ---
src/libide/completion/ide-completion.c | 5 ++---
4 files changed, 9 insertions(+), 10 deletions(-)
---
diff --git a/src/libide/completion/ide-completion-private.h b/src/libide/completion/ide-completion-private.h
index 73b4f161b..b55c64ff1 100644
--- a/src/libide/completion/ide-completion-private.h
+++ b/src/libide/completion/ide-completion-private.h
@@ -71,5 +71,7 @@ void _ide_completion_list_box_row_attach (IdeCompletio
gint _ide_completion_list_box_row_get_x_offset (IdeCompletionListBoxRow *self,
GtkWidget *toplevel);
IdeCompletionOverlay *_ide_completion_overlay_new (void);
+void _ide_completion_provider_load (IdeCompletionProvider *self,
+ IdeContext *context);
G_END_DECLS
diff --git a/src/libide/completion/ide-completion-provider.c b/src/libide/completion/ide-completion-provider.c
index fbecf3626..2fcde8237 100644
--- a/src/libide/completion/ide-completion-provider.c
+++ b/src/libide/completion/ide-completion-provider.c
@@ -268,11 +268,12 @@ ide_completion_provider_key_activates (IdeCompletionProvider *self,
}
void
-ide_completion_provider_load (IdeCompletionProvider *self,
- IdeContext *context)
+_ide_completion_provider_load (IdeCompletionProvider *self,
+ IdeContext *context)
{
g_return_if_fail (IDE_IS_COMPLETION_PROVIDER (self));
- g_return_if_fail (IDE_IS_COMPLETION_CONTEXT (context));
+ g_return_if_fail (IDE_IS_CONTEXT (context));
- IDE_COMPLETION_PROVIDER_GET_IFACE (self)->load (self, context);
+ if (IDE_COMPLETION_PROVIDER_GET_IFACE (self)->load)
+ IDE_COMPLETION_PROVIDER_GET_IFACE (self)->load (self, context);
}
diff --git a/src/libide/completion/ide-completion-provider.h b/src/libide/completion/ide-completion-provider.h
index 8aef10eda..007db7305 100644
--- a/src/libide/completion/ide-completion-provider.h
+++ b/src/libide/completion/ide-completion-provider.h
@@ -65,9 +65,6 @@ struct _IdeCompletionProviderInterface
const GdkEventKey *key);
};
-IDE_AVAILABLE_IN_3_30
-void ide_completion_provider_load (IdeCompletionProvider *self,
- IdeContext *context);
IDE_AVAILABLE_IN_3_30
GIcon *ide_completion_provider_get_icon (IdeCompletionProvider *self);
IDE_AVAILABLE_IN_3_30
diff --git a/src/libide/completion/ide-completion.c b/src/libide/completion/ide-completion.c
index 1071dfe24..93f63c172 100644
--- a/src/libide/completion/ide-completion.c
+++ b/src/libide/completion/ide-completion.c
@@ -638,12 +638,11 @@ ide_completion_addins_extension_added_cb (IdeExtensionSetAdapter *adapter,
g_assert (plugin_info != NULL);
g_assert (IDE_IS_COMPLETION_PROVIDER (provider));
- /* TODO: Remove this when no longer necessary */
-
if ((buffer = ide_completion_get_buffer (self)) && IDE_IS_BUFFER (buffer))
{
+ /* TODO: Remove this when no longer necessary */
IdeContext *context = ide_buffer_get_context (IDE_BUFFER (buffer));
- ide_completion_provider_load (provider, context);
+ _ide_completion_provider_load (provider, context);
}
ide_completion_add_provider (self, provider);
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]