[gimp] desktop: remove the double <releases> trick.
- From: Jehan Pagès <jehanp src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gimp] desktop: remove the double <releases> trick.
- Date: Sun, 13 May 2018 13:35:11 +0000 (UTC)
commit 0492157dd2851a6bfa42af106d5d3809b9924fd2
Author: Jehan <jehan girinstud io>
Date: Sun May 13 15:27:54 2018 +0200
desktop: remove the double <releases> trick.
This was added in commits 447d9bbc56 and fb6328b9ad.
With it, the validation succeeds. Still I am actually not sure that is
proper appdata format. Also we have issues of metadata not shown for our
flatpak package, and I am wondering if this could be the issue.
So let's get rid of this hack.
Also temporarily commenting out the appdata unit test because it fails
without, because of a bug in appstream-util. This bug has been fixed
since, but there are no releases containing this fix yet.
See: https://github.com/hughsie/appstream-glib/issues/234
We'll reactivate the tests later.
desktop/org.gimp.GIMP.appdata.xml.in.in | 2 --
desktop/test-appdata.sh | 2 +-
2 files changed, 1 insertions(+), 3 deletions(-)
---
diff --git a/desktop/org.gimp.GIMP.appdata.xml.in.in b/desktop/org.gimp.GIMP.appdata.xml.in.in
index f439f12..c4a394e 100644
--- a/desktop/org.gimp.GIMP.appdata.xml.in.in
+++ b/desktop/org.gimp.GIMP.appdata.xml.in.in
@@ -143,9 +143,7 @@
<_p>For more information, see https://www.gimp.org/news/2018/04/27/gimp-2-10-0-released/</_p>
</description>
</release>
- </releases>
- <releases>
<release version="2.10.0~rc2" date="2018-04-17" type="development">
<description>
<_p>
diff --git a/desktop/test-appdata.sh b/desktop/test-appdata.sh
index d4bb50a..b6735e6 100755
--- a/desktop/test-appdata.sh
+++ b/desktop/test-appdata.sh
@@ -2,5 +2,5 @@
# TODO: use validate-strict when the last errors for a strict validation
# are fixed.
-appstream-util validate-relax ${GIMP_TESTING_ABS_TOP_BUILDDIR}/desktop/org.gimp.GIMP.appdata.xml && \
+# appstream-util validate-relax ${GIMP_TESTING_ABS_TOP_BUILDDIR}/desktop/org.gimp.GIMP.appdata.xml && \
appstream-util validate-relax ${GIMP_TESTING_ABS_TOP_BUILDDIR}/desktop/gimp-data-extras.metainfo.xml
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]