[pitivi/1.0] render: Stop forcing format in restriction caps
- From: Thibault Saunier <tsaunier src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [pitivi/1.0] render: Stop forcing format in restriction caps
- Date: Fri, 18 May 2018 18:00:11 +0000 (UTC)
commit 1850db4664811f82c1e24883b7f208c3836d5757
Author: Thibault Saunier <tsaunier igalia com>
Date: Fri Apr 20 20:00:50 2018 -0300
render: Stop forcing format in restriction caps
This was a workaround for decoders that were allowing upstream
renegotiation while not actually supporting it, or while downstream
was fixed and encoder upstream renegotiation often leads to new
output format, thus the renegotiation was leading to NNEs
This is possible thanks to the following commit in -base.
commit 9ce8cf89ba2d2047b4735f8a834d4659d12f91d1
Author: Thibault Saunier <tsaunier igalia com>
Date: Sun Apr 22 10:49:29 2018 -0300
encodebin: Also lock input caps when dynamic output is disabled
With the way caps negotiation work in encoders, the only way to ensure
that no downstream renegotiation is done in the encoder is to also lock
upstream caps. Anyway with the current behavior upstream of encoders
*require* to handle any file format so locking upstream format should
be safe.
https://bugzilla.gnome.org/show_bug.cgi?id=795464
Bump our GStreamer dependency to 1.14.1 as it is now required.
pitivi/check.py | 2 +-
pitivi/project.py | 6 ------
2 files changed, 1 insertion(+), 7 deletions(-)
---
diff --git a/pitivi/check.py b/pitivi/check.py
index 24b50561..a0fc4184 100644
--- a/pitivi/check.py
+++ b/pitivi/check.py
@@ -417,7 +417,7 @@ def initialize_modules():
# a specific version requirement, they have the "None" value.
GST_API_VERSION = "1.0"
-GST_VERSION = "1.12.3"
+GST_VERSION = "1.14.1"
GTK_API_VERSION = "3.0"
GLIB_API_VERSION = "2.0"
HARD_DEPENDENCIES = [GICheck("3.20.0"),
diff --git a/pitivi/project.py b/pitivi/project.py
index 5ade84a5..5c32d470 100644
--- a/pitivi/project.py
+++ b/pitivi/project.py
@@ -1701,8 +1701,6 @@ class Project(Loggable, GES.Project):
"height": 576,
"framerate": Gst.Fraction(25, 1),
"pixel-aspect-ratio": Gst.Fraction(1, 1),
- "format": Gst.ValueArray(ALL_RAW_VIDEO_FORMATS),
-
}
prev_vals = None
@@ -1715,10 +1713,6 @@ class Project(Loggable, GES.Project):
else:
ref_restrictions = profile.get_restriction()
- for struct in ref_restrictions:
- if not struct["format"]:
- struct["format"] = Gst.ValueArray(ALL_RAW_VIDEO_FORMATS)
-
self._ensureRestrictions(profile, defaults, ref_restrictions,
prev_vals)
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]