[balsa/wip/gtk4: 209/351] Widgets are visible by default
- From: Peter Bloomfield <peterb src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [balsa/wip/gtk4: 209/351] Widgets are visible by default
- Date: Wed, 23 May 2018 21:34:31 +0000 (UTC)
commit 924cb295df5daa9880ac3d83da34912580242d15
Author: Peter Bloomfield <PeterBloomfield bellsouth net>
Date: Wed Mar 7 19:39:58 2018 -0500
Widgets are visible by default
so we need to show only top-level windows, and any widget that was
previously explicitly hidden.
libbalsa/html.c | 1 -
libbalsa/identity.c | 1 -
libbalsa/libbalsa-gpgme-cb.c | 2 --
libbalsa/libbalsa-gpgme-widgets.c | 2 --
libbalsa/libbalsa-progress.c | 1 -
libbalsa/libbalsa.c | 4 ----
libinit_balsa/assistant_page_directory.c | 3 +--
src/ab-main.c | 6 ------
src/ab-window.c | 18 ------------------
src/address-book-config.c | 2 --
src/balsa-app.c | 1 -
src/balsa-index.c | 2 --
src/balsa-mblist.c | 3 ---
src/balsa-message.c | 4 ----
src/balsa-mime-widget-crypto.c | 1 -
src/balsa-mime-widget-message.c | 8 --------
src/balsa-mime-widget-text.c | 8 --------
src/information-dialog.c | 1 -
src/mailbox-conf.c | 3 ---
src/mailbox-node.c | 3 ---
src/main-window.c | 23 +----------------------
src/message-window.c | 2 --
src/pref-manager.c | 3 ---
src/print-gtk.c | 2 --
src/sendmsg-window.c | 22 ----------------------
src/store-address.c | 2 --
src/toolbar-factory.c | 5 -----
27 files changed, 2 insertions(+), 131 deletions(-)
---
diff --git a/libbalsa/html.c b/libbalsa/html.c
index 2260614..65a218b 100644
--- a/libbalsa/html.c
+++ b/libbalsa/html.c
@@ -1107,7 +1107,6 @@ lbh_show_info_bar(LibBalsaWebKitInfo * info)
gtk_info_bar_set_message_type(info_bar, GTK_MESSAGE_QUESTION);
info->has_info_bar = TRUE;
- gtk_widget_show_all(info_bar_widget);
}
/*
diff --git a/libbalsa/identity.c b/libbalsa/identity.c
index d9f5a40..fe4c0fa 100644
--- a/libbalsa/identity.c
+++ b/libbalsa/identity.c
@@ -1305,7 +1305,6 @@ md_face_path_changed(const gchar * filename, gboolean active,
gtk_container_foreach(GTK_CONTAINER(face_box),
(GtkCallback) gtk_widget_destroy, NULL);
gtk_box_pack_start(GTK_BOX(face_box), image);
- gtk_widget_show(face_box);
g_free(content);
}
diff --git a/libbalsa/libbalsa-gpgme-cb.c b/libbalsa/libbalsa-gpgme-cb.c
index fd64640..83f416c 100644
--- a/libbalsa/libbalsa-gpgme-cb.c
+++ b/libbalsa/libbalsa-gpgme-cb.c
@@ -276,7 +276,6 @@ lb_gpgme_select_key(const gchar * user_name, lb_key_sel_md_t mode, GList * keys,
/* set window size to 2/3 of the parent */
gtk_window_get_size(parent, &width, &height);
gtk_window_set_default_size(GTK_WINDOW(dialog), (2 * width) / 3, (2 * height) / 3);
- gtk_widget_show(gtk_dialog_get_content_area(GTK_DIALOG(dialog)));
if (gtk_dialog_run(GTK_DIALOG(dialog)) != GTK_RESPONSE_OK) {
use_key = NULL;
@@ -368,7 +367,6 @@ get_passphrase_real(const gchar * uid_hint, const gchar * passphrase_info,
entry = gtk_entry_new();
gtk_box_pack_start(GTK_BOX(vbox), entry);
- gtk_widget_show(gtk_dialog_get_content_area(GTK_DIALOG(dialog)));
gtk_entry_set_width_chars(GTK_ENTRY(entry), 40);
gtk_entry_set_visibility(GTK_ENTRY(entry), FALSE);
diff --git a/libbalsa/libbalsa-gpgme-widgets.c b/libbalsa/libbalsa-gpgme-widgets.c
index 5534c8c..0205e19 100644
--- a/libbalsa/libbalsa-gpgme-widgets.c
+++ b/libbalsa/libbalsa-gpgme-widgets.c
@@ -413,8 +413,6 @@ libbalsa_key_dialog(GtkWindow *parent,
key_data = libbalsa_gpgme_key(key, NULL, subkey_capa, TRUE);
gtk_container_add(GTK_CONTAINER(scrolledw), key_data);
- gtk_widget_show(hbox);
-
return dialog;
}
diff --git a/libbalsa/libbalsa-progress.c b/libbalsa/libbalsa-progress.c
index 881d6df..4a19da3 100644
--- a/libbalsa/libbalsa-progress.c
+++ b/libbalsa/libbalsa-progress.c
@@ -202,7 +202,6 @@ libbalsa_progress_dialog_ensure_real(ProgressDialog *progress_dialog,
progress_widget = create_progress_widget(progress_id);
gtk_revealer_set_reveal_child(GTK_REVEALER(progress_widget), TRUE);
gtk_box_pack_start(GTK_BOX(content_box), progress_widget);
- gtk_widget_show(progress_widget);
}
}
diff --git a/libbalsa/libbalsa.c b/libbalsa/libbalsa.c
index 96a58b3..25683a1 100644
--- a/libbalsa/libbalsa.c
+++ b/libbalsa/libbalsa.c
@@ -543,11 +543,9 @@ ask_cert_real(void *data)
vbox = GTK_BOX(gtk_dialog_get_content_area(GTK_DIALOG(dialog)));
gtk_box_set_spacing(vbox, 1);
gtk_box_pack_start(vbox, label);
- gtk_widget_show(label);
gtk_widget_set_vexpand(cert_widget, TRUE);
gtk_box_pack_start(vbox, cert_widget);
- gtk_widget_show(cert_widget);
switch(gtk_dialog_run(GTK_DIALOG(dialog))) {
case 0:
@@ -644,8 +642,6 @@ ask_cert_real(void *data)
gtk_widget_set_vexpand(label, TRUE);
gtk_box_pack_start(vbox, label);
- gtk_widget_show(label);
-
switch(gtk_dialog_run(GTK_DIALOG(dialog))) {
case 0: i = 1; break;
case 1: i = 2; break;
diff --git a/libinit_balsa/assistant_page_directory.c b/libinit_balsa/assistant_page_directory.c
index 94cc9f0..4606ab7 100644
--- a/libinit_balsa/assistant_page_directory.c
+++ b/libinit_balsa/assistant_page_directory.c
@@ -222,7 +222,7 @@ verify_button(BalsaDruidPageDirectory * dir)
button = gtk_button_new_with_mnemonic(_("_Verify locations"));
g_signal_connect(button, "clicked",
G_CALLBACK(verify_button_clicked_cb), dir);
- gtk_widget_show(button);
+
return button;
}
@@ -296,7 +296,6 @@ balsa_druid_page_directory_init(BalsaDruidPageDirectory * dir,
}
gtk_box_pack_start(GTK_BOX(page), GTK_WIDGET(grid));
- gtk_widget_show(GTK_WIDGET(grid));
gtk_box_pack_end(GTK_BOX(page), verify_button(dir));
diff --git a/src/ab-main.c b/src/ab-main.c
index c2396a1..1e04bc4 100644
--- a/src/ab-main.c
+++ b/src/ab-main.c
@@ -784,7 +784,6 @@ bab_window_list_new(void)
LIST_COLUMN_ADDRSPEC, NULL);
gtk_tree_view_append_column(GTK_TREE_VIEW(tree), column);
- gtk_widget_show(tree);
return tree;
}
@@ -907,15 +906,11 @@ bab_get_filter_box(void)
GtkWidget *search_hbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 2);
GtkWidget *find_label, *find_entry, *button;
- gtk_widget_show(search_hbox);
find_label = gtk_label_new_with_mnemonic(_("F_ilter:"));
- gtk_widget_show(find_label);
gtk_box_pack_start(GTK_BOX(search_hbox), find_label);
find_entry = gtk_entry_new();
- gtk_widget_show(find_entry);
gtk_widget_set_hexpand(find_entry, TRUE);
gtk_box_pack_start(GTK_BOX(search_hbox), find_entry);
- gtk_widget_show(search_hbox);
gtk_label_set_mnemonic_widget(GTK_LABEL(find_label), find_entry);
button = gtk_button_new_from_icon_name("gtk-ok");
gtk_box_pack_start(GTK_BOX(search_hbox), button);
@@ -973,7 +968,6 @@ bab_window_new(GtkApplication * application)
gtk_box_pack_start(GTK_BOX(browse_widget), bab_get_filter_box());
scroll = gtk_scrolled_window_new(NULL, NULL);
- gtk_widget_show(scroll);
gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(scroll),
GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
gtk_widget_set_hexpand(scroll, TRUE);
diff --git a/src/ab-window.c b/src/ab-window.c
index 2f51c1f..071e143 100644
--- a/src/ab-window.c
+++ b/src/ab-window.c
@@ -197,7 +197,6 @@ balsa_ab_window_list(BalsaAbWindow * ab, GCallback row_activated_cb)
selection = gtk_tree_view_get_selection(GTK_TREE_VIEW(tree));
gtk_tree_selection_set_mode(selection, GTK_SELECTION_MULTIPLE);
- gtk_widget_show(tree);
g_signal_connect(G_OBJECT(tree), "row-activated", row_activated_cb,
ab);
return tree;
@@ -286,15 +285,12 @@ balsa_ab_window_init(BalsaAbWindow *ab)
gtk_grid_set_column_spacing(GTK_GRID(grid), 12);
gtk_widget_set_vexpand(grid, TRUE);
gtk_box_pack_start(vbox, grid);
- gtk_widget_show(grid);
/* -- grid column 1 -- */
/* Entry widget for finding an address */
find_label = gtk_label_new_with_mnemonic(_("_Search for Name:"));
- gtk_widget_show(find_label);
ab->filter_entry = gtk_entry_new();
- gtk_widget_show(ab->filter_entry);
gtk_label_set_mnemonic_widget(GTK_LABEL(find_label), ab->filter_entry);
g_signal_connect(G_OBJECT(ab->filter_entry), "changed",
G_CALLBACK(balsa_ab_window_find), ab);
@@ -305,7 +301,6 @@ balsa_ab_window_init(BalsaAbWindow *ab)
gtk_box_pack_start(GTK_BOX(box2), find_label);
gtk_widget_set_hexpand(ab->filter_entry, TRUE);
gtk_box_pack_start(GTK_BOX(box2), ab->filter_entry);
- gtk_widget_show(GTK_WIDGET(box2));
/* A scrolled window for the address list */
@@ -317,7 +312,6 @@ balsa_ab_window_init(BalsaAbWindow *ab)
GTK_POLICY_AUTOMATIC);
gtk_widget_set_vexpand(scrolled_window, TRUE);
gtk_grid_attach(GTK_GRID(grid), scrolled_window, 0, 1, 1, 1);
- gtk_widget_show(scrolled_window);
gtk_container_add(GTK_CONTAINER(scrolled_window), ab->address_list);
gtk_widget_set_size_request(scrolled_window, 300, 250);
@@ -326,20 +320,17 @@ balsa_ab_window_init(BalsaAbWindow *ab)
gtk_button_box_set_layout(GTK_BUTTON_BOX(hbox), GTK_BUTTONBOX_SPREAD);
gtk_widget_set_vexpand(hbox, FALSE);
gtk_grid_attach(GTK_GRID(grid), hbox, 0, 2, 1, 1);
- gtk_widget_show(GTK_WIDGET(hbox));
w = gtk_button_new_with_mnemonic(_("Run _Editor"));
g_signal_connect(w, "clicked",
G_CALLBACK(balsa_ab_window_run_editor), NULL);
gtk_box_pack_start(GTK_BOX(hbox), w);
- gtk_widget_show(w);
w = gtk_button_new_with_mnemonic(_("_Re-import"));
g_signal_connect(G_OBJECT(w), "clicked",
G_CALLBACK(balsa_ab_window_reload),
ab);
gtk_box_pack_start(GTK_BOX(hbox), w);
- gtk_widget_show(w);
balsa_ab_window_load(ab);
@@ -349,12 +340,10 @@ balsa_ab_window_init(BalsaAbWindow *ab)
gtk_widget_set_vexpand(ab->arrow_box, TRUE);
gtk_widget_set_hexpand(ab->arrow_box, FALSE);
gtk_grid_attach(GTK_GRID(grid), ab->arrow_box, 1, 1, 1, 1);
- gtk_widget_show(ab->arrow_box);
w = gtk_button_new_from_icon_name("go-next-symbolic");
gtk_widget_set_hexpand(w, TRUE);
gtk_box_pack_start(GTK_BOX(ab->arrow_box), w);
- gtk_widget_show(w);
g_signal_connect(G_OBJECT(w), "clicked",
G_CALLBACK(balsa_ab_window_move_to_recipient_list),
ab);
@@ -362,7 +351,6 @@ balsa_ab_window_init(BalsaAbWindow *ab)
w = gtk_button_new_from_icon_name("go-previous-symbolic");
gtk_widget_set_hexpand(w, TRUE);
gtk_box_pack_start(GTK_BOX(ab->arrow_box), w);
- gtk_widget_show(w);
g_signal_connect(G_OBJECT(w), "clicked",
G_CALLBACK(balsa_ab_window_remove_from_recipient_list),
ab);
@@ -370,14 +358,12 @@ balsa_ab_window_init(BalsaAbWindow *ab)
/* -- grid column 3 -- */
/* label for selected addresses in compose mode */
ab->send_to_label = gtk_label_new(_("Send-To"));
- gtk_widget_show(ab->send_to_label);
gtk_grid_attach(GTK_GRID(grid), ab->send_to_label, 2, 0, 1, 1);
/* list for selected addresses in compose mode */
ab->send_to_list = gtk_scrolled_window_new(NULL, NULL);
gtk_widget_set_vexpand(ab->send_to_list, TRUE);
gtk_widget_set_hexpand(ab->send_to_list, TRUE);
- gtk_widget_show(ab->send_to_list);
gtk_scrolled_window_set_policy(GTK_SCROLLED_WINDOW(ab->send_to_list),
GTK_POLICY_AUTOMATIC, GTK_POLICY_AUTOMATIC);
gtk_grid_attach(GTK_GRID(grid), ab->send_to_list, 2, 1, 1, 1);
@@ -386,20 +372,17 @@ balsa_ab_window_init(BalsaAbWindow *ab)
/* mode switching stuff */
frame = gtk_frame_new(_("Treat multiple addresses as:"));
- gtk_widget_show(frame);
ab->single_address_mode_radio = gtk_radio_button_new_with_label
(NULL, _("alternative addresses for the same person"));
label = gtk_bin_get_child(GTK_BIN(ab->single_address_mode_radio));
gtk_label_set_xalign((GtkLabel *) label, 0.0);
- gtk_widget_show(ab->single_address_mode_radio);
ab->dist_address_mode_radio = gtk_radio_button_new_with_label_from_widget
(GTK_RADIO_BUTTON(ab->single_address_mode_radio),
_("a distribution list"));
label = gtk_bin_get_child(GTK_BIN(ab->dist_address_mode_radio));
gtk_label_set_xalign((GtkLabel *) label, 0.0);
- gtk_widget_show(ab->dist_address_mode_radio);
ab->toggle_handler_id =
g_signal_connect(G_OBJECT(ab->single_address_mode_radio),
"toggled",
@@ -417,7 +400,6 @@ balsa_ab_window_init(BalsaAbWindow *ab)
gtk_container_add(GTK_CONTAINER(frame), box2);
gtk_box_pack_start(GTK_BOX(box2), ab->single_address_mode_radio);
gtk_box_pack_start(GTK_BOX(box2), ab->dist_address_mode_radio);
- gtk_widget_show(box2);
gtk_box_pack_start(vbox, frame);
gtk_widget_grab_focus(ab->filter_entry);
diff --git a/src/address-book-config.c b/src/address-book-config.c
index ddb5955..e771c2f 100644
--- a/src/address-book-config.c
+++ b/src/address-book-config.c
@@ -528,8 +528,6 @@ create_ldap_dialog(AddressBookConfig * abc)
add_radio_buttons(grid, 7, abc);
- gtk_widget_show(grid);
-
g_free(base);
g_free(name);
g_free(host);
diff --git a/src/balsa-app.c b/src/balsa-app.c
index 4b36134..5df0232 100644
--- a/src/balsa-app.c
+++ b/src/balsa-app.c
@@ -104,7 +104,6 @@ ask_password_real(LibBalsaServer * server, LibBalsaMailbox * mbox)
if(server->remember_passwd)
gtk_toggle_button_set_active(GTK_TOGGLE_BUTTON(rememb), TRUE);
- gtk_widget_show(content_area);
gtk_entry_set_activates_default(GTK_ENTRY(entry), TRUE);
gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_OK);
gtk_widget_grab_focus (entry);
diff --git a/src/balsa-index.c b/src/balsa-index.c
index 9dbbf64..6c06709 100644
--- a/src/balsa-index.c
+++ b/src/balsa-index.c
@@ -1949,8 +1949,6 @@ bndx_do_popup(BalsaIndex * index, const GdkEvent * event)
gtk_menu_item_set_submenu(GTK_MENU_ITEM(index->move_to_item),
submenu);
- gtk_widget_show(menu);
-
if (event != NULL) {
gtk_menu_popup_at_pointer(GTK_MENU(menu), event);
} else {
diff --git a/src/balsa-mblist.c b/src/balsa-mblist.c
index 291459e..58c0692 100644
--- a/src/balsa-mblist.c
+++ b/src/balsa-mblist.c
@@ -1687,8 +1687,6 @@ bmbl_mru_menu(GtkWindow * window, GList ** url_list,
G_CALLBACK(bmbl_mru_show_tree), mru,
(GClosureNotify) g_free, (GConnectFlags) 0);
- gtk_widget_show(menu);
-
return menu;
}
@@ -1791,7 +1789,6 @@ bmbl_mru_show_tree(GtkWidget * widget, gpointer data)
GTK_POLICY_AUTOMATIC,
GTK_POLICY_AUTOMATIC);
gtk_container_add(GTK_CONTAINER(scroll), mblist);
- gtk_widget_show(scroll);
dialog =
gtk_dialog_new_with_buttons(_("Choose destination folder"),
diff --git a/src/balsa-message.c b/src/balsa-message.c
index ba3cf08..4da666d 100644
--- a/src/balsa-message.c
+++ b/src/balsa-message.c
@@ -935,14 +935,12 @@ tree_mult_selection_popup(BalsaMessage * bm, const GdkEvent * event,
g_object_ref_sink(bm->save_all_popup);
menu_item =
gtk_menu_item_new_with_label (_("Save selected as…"));
- gtk_widget_show(menu_item);
g_signal_connect (G_OBJECT (menu_item), "activate",
G_CALLBACK (part_context_save_all_cb),
(gpointer) bm->save_all_list);
gtk_menu_shell_append (GTK_MENU_SHELL (bm->save_all_popup), menu_item);
menu_item =
gtk_menu_item_new_with_label (_("Save selected to folder…"));
- gtk_widget_show(menu_item);
g_signal_connect (G_OBJECT (menu_item), "activate",
G_CALLBACK (part_context_dump_all_cb),
(gpointer) bm->save_all_list);
@@ -1528,7 +1526,6 @@ display_face(BalsaMessage * bm)
}
gtk_box_pack_start(GTK_BOX(face_box), image);
- gtk_widget_show(face_box);
}
static void
@@ -1622,7 +1619,6 @@ part_create_menu (BalsaPartInfo* info)
gtk_menu_item_set_submenu(GTK_MENU_ITEM(menu_item), submenu);
}
- gtk_widget_show (info->popup_menu);
g_free (content_type);
}
diff --git a/src/balsa-mime-widget-crypto.c b/src/balsa-mime-widget-crypto.c
index 5620bdf..06c8f8e 100644
--- a/src/balsa-mime-widget-crypto.c
+++ b/src/balsa-mime-widget-crypto.c
@@ -365,7 +365,6 @@ show_public_key_data(GtkExpander *expander,
key_widget = libbalsa_gpgme_key(body->sig_info->key, body->sig_info->fingerprint, 0U,
FALSE);
gtk_box_pack_start(vbox, key_widget);
gtk_box_reorder_child(vbox, key_widget, 1U);
- gtk_widget_show(key_widget);
}
}
}
diff --git a/src/balsa-mime-widget-message.c b/src/balsa-mime-widget-message.c
index 3c07476..a8d36f8 100644
--- a/src/balsa-mime-widget-message.c
+++ b/src/balsa-mime-widget-message.c
@@ -446,18 +446,15 @@ bm_header_extend_popup(GtkWidget * widget, GtkMenu * menu, gpointer arg)
GtkWidget *separator = gtk_separator_menu_item_new();
gtk_menu_shell_append(GTK_MENU_SHELL(menu), separator);
- gtk_widget_show(separator);
menu_item = gtk_menu_item_new_with_label(_("Reply…"));
g_signal_connect(G_OBJECT(menu_item), "activate",
G_CALLBACK(bm_header_ctx_menu_reply),
arg);
gtk_menu_shell_append(GTK_MENU_SHELL(menu), menu_item);
- gtk_widget_show(menu_item);
menu_item = gtk_menu_item_new_with_mnemonic(_("_Copy to folder…"));
gtk_menu_shell_append(GTK_MENU_SHELL(menu), menu_item);
- gtk_widget_show(menu_item);
submenu =
balsa_mblist_mru_menu(GTK_WINDOW
@@ -466,7 +463,6 @@ bm_header_extend_popup(GtkWidget * widget, GtkMenu * menu, gpointer arg)
G_CALLBACK(balsa_message_copy_part), arg);
gtk_menu_item_set_submenu(GTK_MENU_ITEM(menu_item),
submenu);
- gtk_widget_show(submenu);
}
static GtkWidget *
@@ -485,7 +481,6 @@ bm_header_widget_new(BalsaMessage * bm, GtkWidget * const * buttons)
grid = gtk_grid_new();
gtk_grid_set_column_spacing(GTK_GRID(grid), 12);
- gtk_widget_show(grid);
g_signal_connect(grid, "notify::has-focus",
G_CALLBACK(balsa_mime_widget_check_focus), bm);
@@ -607,7 +602,6 @@ add_header_gchar(GtkGrid * grid, const gchar * header, const gchar * label,
gtk_label_set_selectable(GTK_LABEL(lab), TRUE);
gtk_widget_set_halign(lab, GTK_ALIGN_START);
gtk_widget_set_valign(lab, GTK_ALIGN_START);
- gtk_widget_show(lab);
if (value && *value != '\0') {
gchar *sanitized;
@@ -654,7 +648,6 @@ add_header_gchar(GtkGrid * grid, const gchar * header, const gchar * label,
hbox = gtk_box_new(GTK_ORIENTATION_HORIZONTAL, 0);
gtk_box_pack_start(GTK_BOX(hbox), value_label);
gtk_box_pack_start(GTK_BOX(hbox), expander);
- gtk_widget_show(hbox);
gtk_grid_attach_next_to(grid, hbox, lab, GTK_POS_RIGHT, 1, 1);
}
@@ -867,7 +860,6 @@ add_header_sigstate(GtkGrid * grid, GMimeGpgmeSigstat * siginfo)
gtk_label_set_markup(GTK_LABEL(label), msg);
g_free(msg);
gtk_widget_set_halign(label, GTK_ALIGN_START);
- gtk_widget_show(label);
gtk_grid_attach_next_to(grid, label, NULL, GTK_POS_BOTTOM, 2, 1);
}
diff --git a/src/balsa-mime-widget-text.c b/src/balsa-mime-widget-text.c
index 0c3ab0d..f5a294b 100644
--- a/src/balsa-mime-widget-text.c
+++ b/src/balsa-mime-widget-text.c
@@ -595,8 +595,6 @@ text_view_url_popup(GtkWidget *widget, GtkMenu *menu, message_url_t *url)
G_CALLBACK (url_send_cb), (gpointer)url);
gtk_menu_shell_append (GTK_MENU_SHELL (menu), menu_item);
- gtk_widget_show(GTK_WIDGET(menu));
-
return TRUE;
}
@@ -636,8 +634,6 @@ text_view_populate_popup(GtkWidget *widget, GtkMenu *menu,
G_CALLBACK (structured_phrases_toggle), mwt);
gtk_menu_shell_append (GTK_MENU_SHELL (menu), menu_item);
}
-
- gtk_widget_show(GTK_WIDGET(menu));
}
@@ -1020,7 +1016,6 @@ draw_cite_bar_real(cite_bar_t * bar, BalsaMimeWidgetText * mwt)
GTK_STYLE_PROVIDER_PRIORITY_APPLICATION);
g_object_unref(css_provider);
- gtk_widget_show(bar->bar);
gtk_text_view_add_child_in_window(view, bar->bar,
GTK_TEXT_WINDOW_TEXT, 0, y_pos);
} else if (bar->y_pos != y_pos || bar->height != height) {
@@ -1157,8 +1152,6 @@ balsa_gtk_html_popup(GtkWidget * html, BalsaMessage * bm)
menu = gtk_menu_new();
bmwt_populate_popup_menu(bm, html, GTK_MENU(menu));
- gtk_widget_show(menu);
-
/* In WebKit2, the context menu signal is asynchronous, so the
* GdkEvent is no longer current; instead it is preserved and passed
* to us: */
@@ -1211,7 +1204,6 @@ bmwt_populate_popup_cb(GtkWidget * widget, GtkMenu * menu, gpointer data)
gtk_container_foreach(GTK_CONTAINER(menu),
(GtkCallback) gtk_widget_destroy, NULL);
bmwt_populate_popup_menu(bm, html, menu);
- gtk_widget_show(GTK_WIDGET(menu));
}
static BalsaMimeWidget *
diff --git a/src/information-dialog.c b/src/information-dialog.c
index 2616e5c..8b30950 100644
--- a/src/information-dialog.c
+++ b/src/information-dialog.c
@@ -263,7 +263,6 @@ balsa_information_list(GtkWindow *parent, LibBalsaInformationType type,
(GTK_DIALOG(information_dialog))),
scrolled_window);
g_object_set(G_OBJECT(scrolled_window), "margin", 6, NULL);
- gtk_widget_show(scrolled_window);
/* The list itself */
information_list = balsa_information_list_new();
diff --git a/src/mailbox-conf.c b/src/mailbox-conf.c
index fba4a50..24d1783 100644
--- a/src/mailbox-conf.c
+++ b/src/mailbox-conf.c
@@ -238,7 +238,6 @@ balsa_server_conf_get_advanced_widget(BalsaServerConf *bsc, LibBalsaServer *s,
g_signal_connect(G_OBJECT (bsc->use_ssl), "toggled",
G_CALLBACK (bsc_ssl_toggled_cb), bsc);
- gtk_widget_show(GTK_WIDGET(bsc->grid));
bsc->used_rows = 2;
gtk_widget_set_sensitive(bsc->tls_option, !use_ssl);
@@ -1335,7 +1334,6 @@ create_pop_mailbox_dialog(MailboxConfWindow *mcw)
/* toggle for enabling pipeling */
mcw->mb_data.pop3.enable_pipe = balsa_server_conf_add_checkbox(&mcw->mb_data.pop3.bsc, _("Overlap
commands"));
- gtk_widget_show(notebook);
gtk_notebook_set_current_page(GTK_NOTEBOOK(notebook), 0);
gtk_widget_grab_focus(mcw->mailbox_name);
@@ -1453,7 +1451,6 @@ create_imap_mailbox_dialog(MailboxConfWindow *mcw)
gtk_notebook_append_page(GTK_NOTEBOOK(notebook), advanced,
gtk_label_new_with_mnemonic(_("_Advanced")));
- gtk_widget_show(notebook);
gtk_notebook_set_current_page(GTK_NOTEBOOK(notebook), 0);
gtk_widget_grab_focus(mcw->mailbox_name?
mcw->mailbox_name : mcw->mb_data.imap.bsc.server);
diff --git a/src/mailbox-node.c b/src/mailbox-node.c
index 67c5c7b..e4e90d1 100644
--- a/src/mailbox-node.c
+++ b/src/mailbox-node.c
@@ -923,7 +923,6 @@ add_menu_entry(GtkWidget * menu, const gchar * label, GCallback cb,
G_CALLBACK(cb), mbnode);
gtk_menu_shell_append(GTK_MENU_SHELL(menu), menuitem);
- gtk_widget_show(menuitem);
}
static void
@@ -1067,12 +1066,10 @@ balsa_mailbox_node_get_context_menu(BalsaMailboxNode * mbnode)
G_CALLBACK(folder_conf_add_imap_cb), NULL);
add_menu_entry(submenu, _("Remote IMAP _subfolder…"),
G_CALLBACK(folder_conf_add_imap_sub_cb), NULL);
- gtk_widget_show(submenu);
/* Translators: popup menu item "New" mailbox or folder */
menuitem = gtk_menu_item_new_with_mnemonic(C_("mailbox", "_New"));
gtk_menu_item_set_submenu(GTK_MENU_ITEM(menuitem), submenu);
- gtk_widget_show(menuitem);
gtk_menu_shell_append(GTK_MENU_SHELL(menu), menuitem);
diff --git a/src/main-window.c b/src/main-window.c
index cce7650..fbfe7c3 100644
--- a/src/main-window.c
+++ b/src/main-window.c
@@ -303,7 +303,6 @@ bw_frame(GtkWidget * widget)
{
GtkWidget *frame = gtk_frame_new(NULL);
gtk_container_add(GTK_CONTAINER(frame), widget);
- gtk_widget_show(frame);
return frame;
}
/* Filter entry widget creation code. We must carefully pass the typed
@@ -477,7 +476,6 @@ bw_create_index_widget(BalsaWindow *bw)
gtk_combo_box_text_insert_text(GTK_COMBO_BOX_TEXT(bw->filter_choice),
i, view_filters[i].str);
gtk_combo_box_set_active(GTK_COMBO_BOX(bw->filter_choice), 0);
- gtk_widget_show(bw->filter_choice);
bw->sos_entry = gtk_entry_new();
/* gtk_label_set_mnemonic_widget(GTK_LABEL(bw->filter_choice),
bw->sos_entry); */
@@ -485,7 +483,6 @@ bw_create_index_widget(BalsaWindow *bw)
G_CALLBACK(bw_check_filter), bw);
gtk_widget_set_hexpand(bw->sos_entry, TRUE);
gtk_box_pack_start(GTK_BOX(bw->sos_bar), bw->sos_entry);
- gtk_widget_show(bw->sos_entry);
button = gtk_button_new_from_icon_name("gtk-ok");
gtk_box_pack_start(GTK_BOX(bw->sos_bar), button);
g_signal_connect(G_OBJECT(bw->sos_entry), "activate",
@@ -499,9 +496,7 @@ bw_create_index_widget(BalsaWindow *bw)
button);
g_signal_connect(G_OBJECT(bw->filter_choice), "changed",
G_CALLBACK(bw_filter_entry_changed), button);
- gtk_widget_show(button);
vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
- gtk_widget_show(bw->sos_bar);
gtk_box_pack_start(GTK_BOX(vbox), bw->sos_bar);
gtk_widget_set_vexpand(bw->notebook, TRUE);
gtk_box_pack_start(GTK_BOX(vbox), bw->notebook);
@@ -511,7 +506,7 @@ bw_create_index_widget(BalsaWindow *bw)
g_list_free(focusable_widgets);
gtk_widget_set_sensitive(button, FALSE);
- gtk_widget_show(vbox);
+
return vbox;
}
@@ -2228,7 +2223,6 @@ balsa_window_new()
bw_set_alt_bindings(window);
window->vbox = gtk_box_new(GTK_ORIENTATION_VERTICAL, 0);
- gtk_widget_show(window->vbox);
gtk_container_add(GTK_CONTAINER(window), window->vbox);
bw_set_menus(window);
@@ -2256,7 +2250,6 @@ balsa_window_new()
window->statusbar);
gtk_widget_set_hexpand(window->statusbar, TRUE);
gtk_box_pack_start(GTK_BOX(hbox), window->statusbar);
- gtk_widget_show(hbox);
gtk_window_set_resizable(GTK_WINDOW(window), TRUE);
gtk_window_set_default_size(GTK_WINDOW(window), balsa_app.mw_width,
@@ -2294,7 +2287,6 @@ balsa_window_new()
/* XXX */
balsa_app.mblist = BALSA_MBLIST(balsa_mblist_new());
- gtk_widget_show(GTK_WIDGET(balsa_app.mblist));
g_object_get(G_OBJECT(balsa_app.mblist), "hadjustment", &hadj,
"vadjustment", &vadj, NULL);
@@ -2315,7 +2307,6 @@ balsa_window_new()
balsa_app.show_mblist);
if (balsa_app.show_mblist) {
- gtk_widget_show(window->mblist);
gtk_paned_set_position(GTK_PANED(window->paned_master),
balsa_app.mblist_width);
} else {
@@ -2330,10 +2321,6 @@ balsa_window_new()
/* Set it to something really high */
gtk_paned_set_position(GTK_PANED(window->paned_slave), G_MAXINT);
- gtk_widget_show(window->paned_slave);
- gtk_widget_show(window->paned_master);
- gtk_widget_show(window->notebook);
-
/* set the toolbar style */
balsa_window_refresh(window);
@@ -2804,8 +2791,6 @@ bw_notebook_label_new(BalsaMailboxNode * mbnode)
G_CALLBACK(bw_mailbox_tab_close_cb), mbnode);
gtk_box_pack_start(GTK_BOX(box), but);
- gtk_widget_show(box);
-
gtk_widget_set_tooltip_text(box, mbnode->mailbox->url);
return box;
}
@@ -2868,7 +2853,6 @@ bw_real_open_mbnode_idle_cb(BalsaWindowRealOpenMbnodeInfo * info)
GTK_POLICY_AUTOMATIC,
GTK_POLICY_AUTOMATIC);
gtk_container_add(GTK_CONTAINER(scroll), GTK_WIDGET(index));
- gtk_widget_show(scroll);
page_num = gtk_notebook_append_page(GTK_NOTEBOOK(window->notebook),
scroll, label);
gtk_notebook_set_tab_reorderable(GTK_NOTEBOOK(window->notebook),
@@ -3876,8 +3860,6 @@ bw_find_real(BalsaWindow * window, BalsaIndex * bindex, gboolean again)
gtk_widget_set_hexpand(button, TRUE);
gtk_box_pack_start(GTK_BOX(box), button);
- gtk_widget_show(vbox);
-
if (cnd->match.string.string)
gtk_entry_set_text(GTK_ENTRY(search_entry),
cnd->match.string.string);
@@ -4153,9 +4135,6 @@ balsa_change_window_layout(BalsaWindow *window)
gtk_paned_set_position(GTK_PANED(window->paned_master),
balsa_app.show_mblist ?
balsa_app.mblist_width : 0);
- gtk_widget_show(window->paned_slave);
- gtk_widget_show(window->paned_master);
-
}
/* PKGW: remember when they change the position of the vpaned. */
diff --git a/src/message-window.c b/src/message-window.c
index 5fbd82b..462ce7a 100644
--- a/src/message-window.c
+++ b/src/message-window.c
@@ -847,7 +847,6 @@ message_window_new(LibBalsaMailbox * mailbox, guint msgno)
return;
}
g_free(ui_file);
- gtk_widget_show(menubar);
#if HAVE_MACOSX_DESKTOP
libbalsa_macosx_menu(window, GTK_MENU_SHELL(menubar));
#else
@@ -896,7 +895,6 @@ message_window_new(LibBalsaMailbox * mailbox, guint msgno)
gtk_widget_set_vexpand(mw->bmessage, TRUE);
gtk_box_pack_start(GTK_BOX(vbox), mw->bmessage);
- gtk_widget_show(vbox);
g_signal_connect(mw->bmessage, "select-part",
G_CALLBACK(mw_select_part_cb), mw);
diff --git a/src/pref-manager.c b/src/pref-manager.c
index ac8958d..294a92d 100644
--- a/src/pref-manager.c
+++ b/src/pref-manager.c
@@ -1641,7 +1641,6 @@ address_book_set_default_cb(GtkTreeView * tree_view)
static void
add_menu_cb(GtkWidget * menu, GtkWidget * widget)
{
- gtk_widget_show(menu);
gtk_menu_popup_at_widget(GTK_MENU(menu), GTK_WIDGET(widget),
GDK_GRAVITY_NORTH_WEST, GDK_GRAVITY_NORTH_WEST,
NULL);
@@ -2883,7 +2882,6 @@ pm_grid_add_misc_group(GtkWidget * grid_widget)
pui->close_mailbox_minutes =
gtk_spin_button_new(close_spinbutton_adj, 1, 0);
gtk_widget_set_hexpand(pui->close_mailbox_minutes, TRUE);
- gtk_widget_show(pui->close_mailbox_minutes);
gtk_widget_set_sensitive(pui->close_mailbox_minutes, FALSE);
pm_grid_attach(grid, pui->close_mailbox_minutes, 2, row, 1, 1);
@@ -2932,7 +2930,6 @@ pm_grid_add_deleting_messages_group(GtkWidget * grid_widget)
expunge_spinbutton_adj = gtk_adjustment_new(120, 1, 1440, 1, 10, 0);
pui->expunge_minutes = gtk_spin_button_new(expunge_spinbutton_adj, 1, 0);
gtk_widget_set_hexpand(pui->expunge_minutes, TRUE);
- gtk_widget_show(pui->expunge_minutes);
gtk_widget_set_sensitive(pui->expunge_minutes, FALSE);
pm_grid_attach(grid, pui->expunge_minutes, 2, row, 1, 1);
diff --git a/src/print-gtk.c b/src/print-gtk.c
index 81d65b8..441a53f 100644
--- a/src/print-gtk.c
+++ b/src/print-gtk.c
@@ -634,8 +634,6 @@ message_prefs_widget(GtkPrintOperation * operation,
"value-changed", G_CALLBACK(check_margins),
gtk_spin_button_get_adjustment(GTK_SPIN_BUTTON(print_prefs->margin_left)));
- gtk_widget_show(page);
-
return page;
}
diff --git a/src/sendmsg-window.c b/src/sendmsg-window.c
index c61758d..d4829c5 100644
--- a/src/sendmsg-window.c
+++ b/src/sendmsg-window.c
@@ -1492,14 +1492,12 @@ show_attachment_widget(BalsaSendmsg *bsmsg)
g_object_ref(child));
paned = gtk_paned_new(GTK_ORIENTATION_VERTICAL);
- gtk_widget_show(paned);
inner_paned = GTK_PANED(paned);
gtk_paned_add1(inner_paned, child);
g_object_unref(child);
child = sw_attachment_list(bsmsg);
- gtk_widget_show(child);
gtk_paned_add2(inner_paned, child);
gtk_paned_set_position(inner_paned, position);
@@ -1551,8 +1549,6 @@ sw_get_user_codeset(BalsaSendmsg * bsmsg, gboolean * change_type,
gtk_box_pack_start(content_box, info);
gtk_widget_set_vexpand(charset_button, TRUE);
gtk_box_pack_start(content_box, charset_button);
- gtk_widget_show(info);
- gtk_widget_show(charset_button);
gtk_dialog_set_default_response(GTK_DIALOG(dialog), GTK_RESPONSE_OK);
if (change_type) {
@@ -1574,7 +1570,6 @@ sw_get_user_codeset(BalsaSendmsg * bsmsg, gboolean * change_type,
charset_button);
gtk_widget_set_hexpand(combo_box, TRUE);
gtk_box_pack_start(GTK_BOX(hbox), combo_box);
- gtk_widget_show(hbox);
}
if (gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_OK) {
@@ -1845,7 +1840,6 @@ add_attachment(BalsaSendmsg * bsmsg, const gchar *filename,
content_type,
G_CALLBACK(attachment_menu_vfs_cb),
(gpointer)attach_data);
- gtk_widget_show(attach_data->popup_menu);
/* append to the list store */
content_desc =libbalsa_vfs_content_description(content_type);
@@ -1922,7 +1916,6 @@ add_urlref_attachment(BalsaSendmsg * bsmsg, gchar *url)
(gpointer)attach_data);
gtk_menu_shell_append(GTK_MENU_SHELL(attach_data->popup_menu),
menu_item);
- gtk_widget_show(attach_data->popup_menu);
/* append to the list store */
gtk_list_store_set(GTK_LIST_STORE(model), &iter,
@@ -2592,7 +2585,6 @@ create_info_pane(BalsaSendmsg * bsmsg)
create_email_or_string_entry(bsmsg, grid, _("F_CC:"), ++row,
bsmsg->fcc);
- gtk_widget_show(grid);
return grid;
}
@@ -2920,8 +2912,6 @@ create_text_area(BalsaSendmsg * bsmsg)
GDK_ACTION_COPY | GDK_ACTION_MOVE | GDK_ACTION_LINK);
gdk_content_formats_unref(formats);
- gtk_widget_show(scroll);
-
return scroll;
}
@@ -3380,7 +3370,6 @@ quote_parts_select_dlg(GtkTreeStore *tree_store, GtkWindow * parent)
/* add, show & run */
gtk_container_add(GTK_CONTAINER(scroll), tree_view);
- gtk_widget_show(hbox);
result = gtk_dialog_run(GTK_DIALOG(dialog)) == GTK_RESPONSE_OK;
gtk_widget_destroy(dialog);
return result;
@@ -4087,7 +4076,6 @@ create_lang_menu(GtkWidget * parent, BalsaSendmsg * bsmsg)
G_CALLBACK(lang_set_cb), bsmsg);
g_object_set_data_full(G_OBJECT(w), BALSA_LANGUAGE_MENU_LANG,
g_strdup(locales[i].locale), g_free);
- gtk_widget_show(w);
gtk_menu_shell_append(GTK_MENU_SHELL(langs), w);
if (!active_item || strcmp(preferred_lang, locales[i].locale) == 0)
@@ -4116,7 +4104,6 @@ create_lang_menu(GtkWidget * parent, BalsaSendmsg * bsmsg)
G_CALLBACK(lang_set_cb), bsmsg);
g_object_set_data_full(G_OBJECT(w), BALSA_LANGUAGE_MENU_LANG,
g_strdup(lang), g_free);
- gtk_widget_show(w);
gtk_menu_shell_append(GTK_MENU_SHELL(langs), w);
if (!active_item || strcmp(preferred_lang, lang) == 0)
@@ -4131,7 +4118,6 @@ create_lang_menu(GtkWidget * parent, BalsaSendmsg * bsmsg)
gtk_check_menu_item_set_active(GTK_CHECK_MENU_ITEM(active_item), TRUE);
g_signal_handlers_unblock_by_func(active_item, lang_set_cb, bsmsg);
gtk_menu_item_set_submenu(GTK_MENU_ITEM(parent), langs);
- gtk_widget_show(parent);
return g_object_get_data(G_OBJECT(active_item), BALSA_LANGUAGE_MENU_LANG);
}
@@ -4520,8 +4506,6 @@ sendmsg_window_set_field(BalsaSendmsg * bsmsg, const gchar * key,
#endif
if(g_ascii_strcasecmp(key, "subject") == 0) {
append_comma_separated(GTK_EDITABLE(bsmsg->subject[1]), val);
- gtk_widget_show(bsmsg->subject[0]);
- gtk_widget_show(bsmsg->subject[1]);
return;
}
@@ -5018,7 +5002,6 @@ subject_not_empty(BalsaSendmsg * bsmsg)
gtk_widget_grab_focus (subj_entry);
gtk_editable_select_region(GTK_EDITABLE(subj_entry), 0, -1);
- gtk_widget_show(dialog_vbox);
response = gtk_dialog_run(GTK_DIALOG(no_subj_dialog));
@@ -5110,7 +5093,6 @@ check_suggest_encryption(BalsaSendmsg * bsmsg)
gtk_box_pack_start(GTK_BOX(hbox), image);
label = gtk_label_new_with_mnemonic(_("Send _encrypted"));
gtk_box_pack_start(GTK_BOX(hbox), label);
- gtk_widget_show(button);
button = gtk_button_new();
gtk_dialog_add_action_widget(GTK_DIALOG(dialog), button, GTK_RESPONSE_NO);
@@ -5124,10 +5106,8 @@ check_suggest_encryption(BalsaSendmsg * bsmsg)
gtk_box_pack_start(GTK_BOX(hbox), image);
label = gtk_label_new_with_mnemonic(_("Send _unencrypted"));
gtk_box_pack_start(GTK_BOX(hbox), label);
- gtk_widget_show(button);
button = gtk_button_new_with_mnemonic(_("_Cancel"));
- gtk_widget_show(button);
gtk_dialog_add_action_widget(GTK_DIALOG(dialog), button, GTK_RESPONSE_CANCEL);
gtk_widget_set_can_default(button, TRUE);
@@ -6636,7 +6616,6 @@ sendmsg_window_new()
g_error_free(error);
return NULL;
}
- gtk_widget_show(menubar);
#if HAVE_MACOSX_DESKTOP
libbalsa_macosx_menu(window, GTK_MENU_SHELL(menubar));
@@ -6689,7 +6668,6 @@ sendmsg_window_new()
bsmsg->paned = paned = gtk_paned_new(GTK_ORIENTATION_VERTICAL);
gtk_widget_set_vexpand(paned, TRUE);
gtk_box_pack_start(GTK_BOX(main_box), paned);
- gtk_widget_show(paned);
/* create the top portion with the to, from, etc in it */
gtk_paned_add1(GTK_PANED(paned), create_info_pane(bsmsg));
diff --git a/src/store-address.c b/src/store-address.c
index e8c4bb9..a6cc2ea 100644
--- a/src/store-address.c
+++ b/src/store-address.c
@@ -220,12 +220,10 @@ store_address_dialog(StoreAddressInfo * info)
if (balsa_app.address_book_list && balsa_app.address_book_list->next) {
/* User has more than one address book, so show the options */
frame = store_address_book_frame(info);
- gtk_widget_show(frame);
gtk_box_pack_start(GTK_BOX(vbox), frame);
}
frame = store_address_note_frame(info);
- gtk_widget_show(frame);
gtk_widget_set_vexpand(frame, TRUE);
gtk_box_pack_start(GTK_BOX(vbox), frame);
diff --git a/src/toolbar-factory.c b/src/toolbar-factory.c
index 1dd1b39..42dc480 100644
--- a/src/toolbar-factory.c
+++ b/src/toolbar-factory.c
@@ -585,8 +585,6 @@ tm_populate(GtkWidget * toolbar, BalsaToolbarModel * model)
gtk_toolbar_set_style(GTK_TOOLBAR(toolbar),
model->style != (GtkToolbarStyle) (-1) ?
model->style : tm_default_style());
-
- gtk_widget_show(toolbar);
}
/* Update a real toolbar when the model has changed.
@@ -755,7 +753,6 @@ tm_popup_context_menu_cb(GtkWidget * toolbar,
GINT_TO_POINTER(info->model->type));
}
- gtk_widget_show(menu);
gtk_menu_attach_to_widget(GTK_MENU(menu), toolbar, NULL);
event = gtk_get_current_event();
@@ -798,7 +795,5 @@ GtkWidget *balsa_toolbar_new(BalsaToolbarModel * model,
g_signal_connect(toolbar, "popup-context-menu",
G_CALLBACK(tm_popup_context_menu_cb), info);
- gtk_widget_show(toolbar);
-
return toolbar;
}
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]
