[gnome-shell-extensions/wip/fmuellner/fix-113-master: 4/17] window-list: Don't override ClutterActor.destroy()
- From: Florian Müllner <fmuellner src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [gnome-shell-extensions/wip/fmuellner/fix-113-master: 4/17] window-list: Don't override ClutterActor.destroy()
- Date: Mon, 12 Nov 2018 23:42:28 +0000 (UTC)
commit 60493faf96e3b53f6831869b1176e66b934c2f69
Author: Florian Müllner <fmuellner gnome org>
Date: Wed Oct 10 15:48:02 2018 +0200
window-list: Don't override ClutterActor.destroy()
Now that PanelMenu.Button was made an StWidget subclass, the destroy()
method actually maps to the ClutterActor method, and overriding it
results in warnings when the extension is disabled. So instead, use
the existing ::destroy handler.
https://gitlab.gnome.org/GNOME/gnome-shell-extensions/issues/113
extensions/window-list/extension.js | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
---
diff --git a/extensions/window-list/extension.js b/extensions/window-list/extension.js
index 2cf8a6a..e81edbf 100644
--- a/extensions/window-list/extension.js
+++ b/extensions/window-list/extension.js
@@ -679,7 +679,7 @@ class WorkspaceIndicator extends PanelMenu.Button {
this._updateMenu.bind(this));
}
- destroy() {
+ _onDestroy() {
for (let i = 0; i < this._workspaceManagerSignals.length; i++)
global.workspace_manager.disconnect(this._workspaceManagerSignals[i]);
@@ -688,7 +688,7 @@ class WorkspaceIndicator extends PanelMenu.Button {
this._settingsChangedId = 0;
}
- super.destroy();
+ super._onDestroy();
}
_updateIndicator() {
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]