[gnome-shell/gnome-3-30] dash: destroy items's child before tooltip

[Florian Müllner <fmuellner src gnome org>]

commit 45b4495886e89373b9af6e1c3eb21bd65e1d0c42
Author: Andrea Azzarone <azzaronea gmail com>
Date:   Fri Nov 16 18:31:56 2018 +0000

    dash: destroy items's child before tooltip
    
    Destroy the DashItemContainer's child from the same handler as the tooltip. This
    will prevent invalid reads when the item is destroyed while its quicklist is
    still open.
    
    Fixes: https://gitlab.gnome.org/GNOME/gnome-shell/issues/781
    
    
    (cherry picked from commit ff2fbf5ae40561b403b721e932d1bc5492532156)

 js/ui/dash.js | 2 ++
 1 file changed, 2 insertions(+)
---
diff --git a/js/ui/dash.js b/js/ui/dash.js
index 9b8bfdd13..fbc06a78e 100644
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -52,6 +52,8 @@ var DashItemContainer = new Lang.Class({
         this.animatingOut = false;
 
         this.connect('destroy', () => {
+            if (this.child != null)
+                this.child.destroy();
             this.label.destroy();
         });
     },