[pitivi/1.0] Remove obsolete TODOs and FIXMEs
- From: Thibault Saunier <tsaunier src gnome org>
- To: commits-list gnome org
- Cc:
- Subject: [pitivi/1.0] Remove obsolete TODOs and FIXMEs
- Date: Thu, 22 Nov 2018 15:52:53 +0000 (UTC)
commit a9db93ed5fdb0a153dcd64501c4e97c25bb03f61
Author: Alexandru Băluț <alexandru balut gmail com>
Date: Sun Nov 18 23:49:43 2018 +0100
Remove obsolete TODOs and FIXMEs
Fixes #2209
pitivi/mainwindow.py | 2 --
pitivi/project.py | 1 -
pitivi/render.py | 1 -
pitivi/timeline/elements.py | 4 ----
pitivi/timeline/previewers.py | 2 +-
pitivi/transitions.py | 4 ----
tests/test_render.py | 1 -
7 files changed, 1 insertion(+), 14 deletions(-)
---
diff --git a/pitivi/mainwindow.py b/pitivi/mainwindow.py
index c9d326c3..4a54089c 100644
--- a/pitivi/mainwindow.py
+++ b/pitivi/mainwindow.py
@@ -743,8 +743,6 @@ class MainWindow(Gtk.ApplicationWindow, Loggable):
self.error("failed to save project")
def _projectManagerProjectSavedCb(self, unused_project_manager, project, uri):
- # FIXME GES: Reimplement Undo/Redo
- # self.app.action_log.checkpoint()
self.updateTitle()
self.save_action.set_enabled(False)
diff --git a/pitivi/project.py b/pitivi/project.py
index 3477478b..5ced5166 100644
--- a/pitivi/project.py
+++ b/pitivi/project.py
@@ -1768,7 +1768,6 @@ class Project(Loggable, GES.Project):
def _emit_change(self, key):
self.emit("rendering-settings-changed", key)
- # TODO: Remove this when it's possible to undo/redo these changes.
self.setModificationState(True)
def _getElementFactoryName(self, elements, profile):
diff --git a/pitivi/render.py b/pitivi/render.py
index 3052c486..ea8237a2 100644
--- a/pitivi/render.py
+++ b/pitivi/render.py
@@ -869,7 +869,6 @@ class RenderDialog(Loggable):
def startAction(self):
"""Starts the render process."""
self._pipeline.set_state(Gst.State.NULL)
- # FIXME: https://github.com/pitivi/gst-editing-services/issues/23
self._pipeline.set_mode(GES.PipelineFlags.RENDER)
encodebin = self._pipeline.get_by_name("internal-encodebin")
self._gstSigId[encodebin] = encodebin.connect(
diff --git a/pitivi/timeline/elements.py b/pitivi/timeline/elements.py
index 9e0c45c6..374ded9d 100644
--- a/pitivi/timeline/elements.py
+++ b/pitivi/timeline/elements.py
@@ -115,11 +115,7 @@ class KeyframeCurve(FigureCanvas, Loggable):
self._ax = figure.add_axes([0, 0, 1, 1], facecolor='None')
# Clear the Axes object.
self._ax.cla()
-
- # FIXME: drawing a grid and ticks would be nice, but
- # matplotlib is too slow for now.
self._ax.grid(False)
-
self._ax.tick_params(axis='both',
which='both',
bottom=False,
diff --git a/pitivi/timeline/previewers.py b/pitivi/timeline/previewers.py
index f5ef4a75..5fa0ba73 100644
--- a/pitivi/timeline/previewers.py
+++ b/pitivi/timeline/previewers.py
@@ -1030,7 +1030,7 @@ class AudioPreviewer(Previewer, Zoomable, Loggable):
self.stop_generation()
elif message.type == Gst.MessageType.ERROR:
- # Something went wrong TODO : recover
+ # Something went wrong.
self.stop_generation()
self._num_failures += 1
if self._num_failures < 2:
diff --git a/pitivi/transitions.py b/pitivi/transitions.py
index 0ce76802..8062aad8 100644
--- a/pitivi/transitions.py
+++ b/pitivi/transitions.py
@@ -115,10 +115,6 @@ class TransitionsListWidget(Gtk.Box, Loggable):
self.iconview_scrollwin = Gtk.ScrolledWindow()
self.iconview_scrollwin.set_shadow_type(Gtk.ShadowType.ETCHED_IN)
- # FIXME: the "never" horizontal scroll policy in GTK2 messes up iconview
- # Re-enable this when we switch to GTK3
- # See also http://python.6.n6.nabble.com/Cannot-shrink-width-of-scrolled-textview-tp1945060.html
- # self.iconview_scrollwin.set_policy(Gtk.PolicyType.NEVER, Gtk.PolicyType.AUTOMATIC)
self.iconview = Gtk.IconView(model=self.storemodel)
self.iconview.set_pixbuf_column(COL_ICON)
diff --git a/tests/test_render.py b/tests/test_render.py
index c495be89..1c83ec08 100644
--- a/tests/test_render.py
+++ b/tests/test_render.py
@@ -302,7 +302,6 @@ class TestRender(BaseTestMediaLibrary):
self.assertEqual(message.type, Gst.MessageType.EOS,
struct.to_string() if struct else message)
asset = GES.UriClipAsset.request_sync(result_file)
- # FIXME Check more things?
self.assertIsNotNone(asset)
if message:
[
Date Prev][
Date Next] [
Thread Prev][
Thread Next]
[
Thread Index]
[
Date Index]
[
Author Index]