[pygobject/coverage-gobject-overrides: 3/4] gobject overrides: assume GObject.ParamFlags.READWRITE exists



commit 4be55f57a75451978f0cf13aeeb02b397b3999dd
Author: Christoph Reiter <reiter christoph gmail com>
Date:   Fri Nov 23 15:58:57 2018 +0100

    gobject overrides: assume GObject.ParamFlags.READWRITE exists
    
    We now depend on a new enough glib

 gi/overrides/GObject.py | 12 ++----------
 1 file changed, 2 insertions(+), 10 deletions(-)
---
diff --git a/gi/overrides/GObject.py b/gi/overrides/GObject.py
index 4a6102d6..26e9f25b 100644
--- a/gi/overrides/GObject.py
+++ b/gi/overrides/GObject.py
@@ -159,20 +159,12 @@ for name in ['PARAM_CONSTRUCT', 'PARAM_CONSTRUCT_ONLY', 'PARAM_LAX_VALIDATION',
     __all__.append(name)
 
 # PARAM_READWRITE should come from the gi module but cannot due to:
-# https://bugzilla.gnome.org/show_bug.cgi?id=687615
+# https://gitlab.gnome.org/GNOME/gobject-introspection/issues/75
 PARAM_READWRITE = GObjectModule.ParamFlags.READABLE | \
     GObjectModule.ParamFlags.WRITABLE
+deprecated_attr("GObject", "PARAM_READWRITE", "GObject.ParamFlags.READWRITE")
 __all__.append("PARAM_READWRITE")
 
-# READWRITE is part of ParamFlags since glib 2.42. Only mark PARAM_READWRITE as
-# deprecated in case ParamFlags.READWRITE is available. Also include the glib
-# version in the warning so it's clear that this needs a newer glib, unlike
-# the other ParamFlags related deprecations.
-# https://bugzilla.gnome.org/show_bug.cgi?id=726037
-if hasattr(GObjectModule.ParamFlags, "READWRITE"):
-    deprecated_attr("GObject", "PARAM_READWRITE",
-                    "GObject.ParamFlags.READWRITE (glib 2.42+)")
-
 
 # Deprecated, use: GObject.SignalFlags.* directly
 for name in ['SIGNAL_ACTION', 'SIGNAL_DETAILED', 'SIGNAL_NO_HOOKS',


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]