[gnome-software/gnome-3-30] loading page: Don't stay stuck in the loading phase on error

[Kalev Lember <klember src gnome org>]

commit 534e352867d4693aa65a1498527738a726a18137
Author: Kalev Lember <klember redhat com>
Date:   Mon Nov 26 13:24:33 2018 +0100

    loading page: Don't stay stuck in the loading phase on error
    
    We lack proper error handling in the loading page, only emitting a
    g_warning on failure.
    
    As a stop gap, this commit makes the loading page ignore the error and
    continue (previously we'd just continue showing the progress bar
    forever), so that we display the main UI and the user can possibly do
    something to fix the error (disable the faulty repo or similar).

 src/gs-loading-page.c | 1 -
 1 file changed, 1 deletion(-)
---
diff --git a/src/gs-loading-page.c b/src/gs-loading-page.c
index e48eb90c..cf8302d9 100644
--- a/src/gs-loading-page.c
+++ b/src/gs-loading-page.c
@@ -111,7 +111,6 @@ gs_loading_page_refresh_cb (GObject *source_object, GAsyncResult *res, gpointer
        /* not sure how to handle this */
        if (!gs_plugin_loader_job_action_finish (plugin_loader, res, &error)) {
                g_warning ("failed to load metadata: %s", error->message);
-               return;
        }
 
        /* no more pulsing */